Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up changes based on #3768 #3773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gautamguptabasant
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

Tests

  • No change in functionality - no new tests added.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

- Addressing comments on the PR apache#3768
- The changes in this PR are around organization of the code only. There are no functional changes.
Copy link
Contributor

@phet phet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the follow up!

(looks good, so long as nothing warranted by the comment I raised)

Comment on lines +136 to +137
salesforceConnector = getConnector(state);
histogramService = new RecordModTimeHistogramService(sfConfig, getConnector(state));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add comment on why another getConnector(state), rather than reusing

edit: reading on I see it doesn't create a new connector... just looks that way

Comment on lines +462 to +463
if (salesforceConnector == null) {
salesforceConnector = new SalesforceConnector(state);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not thread-safe... should it be synchronized? (if there's any need to explicitly close the connector, there's a potential resource leak.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants