Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[task] optimize okhttp3 connection factory #2539

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

Aias00
Copy link
Contributor

@Aias00 Aias00 commented Aug 16, 2024

What's changed?

optimize okhttp3 connection factory, link #2528

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@Aias00 Aias00 closed this Aug 16, 2024
@Aias00 Aias00 reopened this Aug 16, 2024
@tomsun28
Copy link
Contributor

I found this depend the httpclient5, there also have httpclient 4.5.14, okhttp in the system, suggest we unify them and use only one

@Aias00
Copy link
Contributor Author

Aias00 commented Aug 16, 2024

I found this depend the httpclient5, there also have httpclient 4.5.14, okhttp in the system, suggest we unify them and use only one

okay,i will fix them later

@Aias00
Copy link
Contributor Author

Aias00 commented Aug 16, 2024

I found this depend the httpclient5, there also have httpclient 4.5.14, okhttp in the system, suggest we unify them and use only one

hi, how about i submit another pr, and unify the httpcliens version in that pr; cause this modification will effect many codes

@Aias00
Copy link
Contributor Author

Aias00 commented Aug 16, 2024

I found this depend the httpclient5, there also have httpclient 4.5.14, okhttp in the system, suggest we unify them and use only one

image hi. i found many depnedencies import the httpclient 4 version , maybe i should change the httpclient5 to httpclient4

@tomsun28
Copy link
Contributor

okay👍👍, this seem effect many components.

@yuluo-yx
Copy link
Contributor

btw, I found only

okhttp is used here Library.

maybe we can use httpclient instead in our project. spring has given up on okhttp, spring-projects/spring-framework#30919 @Aias00 cc @tomsun28

@Aias00
Copy link
Contributor Author

Aias00 commented Aug 17, 2024

@tomsun28 hi, i tried to degrade the httpclient 5 to httpclient 4. but the truth is that spring-web:6.1.4 would not support httpclient 4 anymore. so i think we can do that changed later, or i can see whether we can upgrade all httpclient4 to httpclient5
image

@Aias00
Copy link
Contributor Author

Aias00 commented Aug 17, 2024

btw, I found only

okhttp is used here Library.
maybe we can use httpclient instead in our project. spring has given up on okhttp, spring-projects/spring-framework#30919 @Aias00 cc @tomsun28

hi, the influxdb-java library has binding okhttp , we can not change that now

image

yuluo-yx
yuluo-yx previously approved these changes Aug 18, 2024
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tomsun28
Copy link
Contributor

@tomsun28 hi, i tried to degrade the httpclient 5 to httpclient 4. but the truth is that spring-web:6.1.4 would not support httpclient 4 anymore. so i think we can do that changed later, or i can see whether we can upgrade all httpclient4 to httpclient5

Hi, yes, maybe we can upgrade httpclient4 to httpclient5 later

@tomsun28 tomsun28 dismissed yuluo-yx’s stale review August 18, 2024 03:01

it seem need to unify the httpclient version

@Calvin979 Calvin979 changed the title [type:task] optimize okhttp3 connection factory [task] optimize okhttp3 connection factory Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants