Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alerter]optimize: Append not resolved alert description to resolved alert #2598

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

loong95
Copy link
Contributor

@loong95 loong95 commented Aug 24, 2024

What's changed?

related issue

Enhanced the resolved alert description by appending the trigger alert's description, improving the context provided during alert resolution.

Suppose an alert is triggered with the following content:

The xxx server is in exception.

Before the modification, the resolved alert description was:

Alert Resolved Notice: status > 0

After the modification, the description becomes:

Alert Resolved Notice: The xxx server is in exception.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28
Copy link
Contributor

hi, how to config the alarm recover message

@loong95
Copy link
Contributor Author

loong95 commented Aug 25, 2024

hi, how to config the alarm recover message

I haven't added any new configurations; I'm simply reusing the alert content from the unresolved alerts.

yuluo-yx and others added 26 commits August 25, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants