Rename gcs.endpoint to gcs.service.host
#1007
Open
+22
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrluis
reviewed
Aug 9, 2024
ndrluis
reviewed
Aug 9, 2024
ndrluis
reviewed
Aug 9, 2024
ndrluis
reviewed
Aug 9, 2024
Co-authored-by: Andre Luis Anastacio <[email protected]>
Co-authored-by: Andre Luis Anastacio <[email protected]>
Co-authored-by: Andre Luis Anastacio <[email protected]>
|
@Fokko, I can solve the missing import. Do you mind? Edit: I discovered that I don't have the permissions to add the commit to your branch. |
kevinjqliu
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
LGTM! Follows the java convention https://iceberg.apache.org/javadoc/0.14.1/constant-values.html
wdyt about using get_first_property_value
Co-authored-by: Kevin Liu <[email protected]>
Co-authored-by: Kevin Liu <[email protected]>
|
Thanks @kevinjqliu, using |
kevinjqliu
reviewed
Nov 5, 2024
Co-authored-by: Kevin Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it in line with Java:
https://github.com/apache/iceberg/blob/6ee6d1327d3811dbd5795c4e87efdc41b7a58eaa/gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java#L32