Pass table-token to commit endpoint #1278

Fokko · 2024-10-31T21:13:49Z

See open-api spec:

https://github.com/apache/iceberg/blob/ea61ee46db17d94f22a5ef11fd913146557bdce7/open-api/rest-catalog-open-api.yaml#L927-L929

Resolves #1113

See open-api spec: https://github.com/apache/iceberg/blob/ea61ee46db17d94f22a5ef11fd913146557bdce7/open-api/rest-catalog-open-api.yaml#L927-L929 Resolves apache#1113

pyiceberg/catalog/rest.py

kevinjqliu

LGTM! The table's auth token is persisted as config, then used on subsequent commit_table requests

Fokko changed the title ~~Pass table-token to subsequent requests~~ Pass table-token to commit endpoint Oct 31, 2024

Pass table-token to subsequent requests

e7de0cc

See open-api spec: https://github.com/apache/iceberg/blob/ea61ee46db17d94f22a5ef11fd913146557bdce7/open-api/rest-catalog-open-api.yaml#L927-L929 Resolves apache#1113

Fokko force-pushed the fd-pass-token branch from 3d26012 to e7de0cc Compare October 31, 2024 22:15

kevinjqliu reviewed Nov 1, 2024

View reviewed changes

pyiceberg/catalog/rest.py Outdated Show resolved Hide resolved

pyiceberg/catalog/rest.py Outdated Show resolved Hide resolved

Replace with constant

9c1efbf

kevinjqliu approved these changes Nov 4, 2024

View reviewed changes

Fokko merged commit 5313df8 into apache:main Nov 5, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass table-token to commit endpoint #1278

Pass table-token to commit endpoint #1278

Fokko commented Oct 31, 2024

kevinjqliu left a comment

Pass table-token to commit endpoint #1278

Pass table-token to commit endpoint #1278

Conversation

Fokko commented Oct 31, 2024

kevinjqliu left a comment

Choose a reason for hiding this comment