Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install extra for sqlite #297

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

kevinjqliu
Copy link
Contributor

@Fokko
Copy link
Contributor

Fokko commented Jan 23, 2024

@kevinjqliu Thanks for working on this!

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/add-install-extra-sqlite branch from bf116c8 to de861d7 Compare January 23, 2024 18:27
@kevinjqliu
Copy link
Contributor Author

@Fokko np. I had to rebase and regenerate the lock file

@kevinjqliu kevinjqliu requested a review from Fokko January 23, 2024 18:28
@Fokko
Copy link
Contributor

Fokko commented Jan 23, 2024

@kevinjqliu There is no upper bound constraint on Ray, and therefore it is bumped to the latest version, which is not compatible for some reason. I've created #298 to fix this for now. If you run revert the changes in poetry.lock and run poetry lock --no-update then it will not update Ray to the latest version.

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/add-install-extra-sqlite branch from d3b3a93 to 21ea2a8 Compare January 23, 2024 20:58
@kevinjqliu
Copy link
Contributor Author

@Fokko thanks, I just ran poetry lock --no-update

@Fokko Fokko merged commit 46d668b into apache:main Jan 23, 2024
6 checks passed
@Fokko
Copy link
Contributor

Fokko commented Jan 23, 2024

Thanks @kevinjqliu for picking this up 🙌

@kevinjqliu kevinjqliu deleted the kevinjqliu/add-install-extra-sqlite branch January 23, 2024 21:50
@HonahX HonahX linked an issue Jan 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add install extra for sqlite
2 participants