Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead links in docs #493

Merged
merged 5 commits into from
Mar 3, 2024
Merged

Conversation

kevinjqliu
Copy link
Contributor

#324 added Github action to check link html links in docs. There are a few dead links in the most recent run.
https://github.com/kevinjqliu/iceberg-python/actions/runs/8124843259/job/22207404913

This PR corrects the dead links or disables checking for those particular cases.

ERROR: 1 dead links found!
[✖] https://iceberg.apache.org/catalog/ → Status: 404

ERROR: 6 dead links found!
[✖] https://10.0.19.25/ → Status: 0
[✖] http://my.proxy.com:8080 → Status: 0
[✖] http://localhost/ → Status: 0
[✖] http://0.0.0.0:4443 → Status: 0
[✖] https://rest-catalog/ws → Status: 0
[✖] https://auth-service/cc → Status: 0

ERROR: 1 dead links found!
[✖] reference/ → Status: 400

Following instructions in
https://github.com/gaurav-nelson/github-action-markdown-link-check

@kevinjqliu kevinjqliu changed the title Kevinjqliu/dead links Fix up dead links in docs Mar 2, 2024
@kevinjqliu kevinjqliu changed the title Fix up dead links in docs Fix dead links in docs Mar 2, 2024
@kevinjqliu kevinjqliu marked this pull request as ready for review March 2, 2024 20:58
@@ -26,6 +26,6 @@
- Releases
- [Verify a release](verify-release.md)
- [How to release](how-to-release.md)
- [Code Reference](reference/)
- [Code Reference](reference/) <!-- markdown-link-check-disable-line -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to build the site locally but received the following error

mkdocs_literate_nav.parser.LiterateNavParseError: Expected no text after <a href="reference/">Code Reference</a>, but got ' <!-- markdown-link-check-disable-line -->'.

Seems we also need to use <!-- markdown-link-check-disable -->/<!-- markdown-link-check-enable--> here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I was able to verify that the updated PR can build the site successfully

cd mkdocs
mkdocs build --strict                                               

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kevinjqliu

BTW, I noticed that the markdown-link-check isn't automatically run with this PR. Is it intended or we need to somehow update the workflow yml?

@kevinjqliu
Copy link
Contributor Author

@HonahX that is weird. The github action is currently configured to run when there are changes to mkdocs/**, which should definitely include this PR.
https://github.com/apache/iceberg-python/blob/main/.github/workflows/check-md-link.yml#L6

I see it ran for the latest commit in my github fork
https://github.com/kevinjqliu/iceberg-python/actions/runs/8133371492/job/22224875853

@kevinjqliu
Copy link
Contributor Author

In fact, I'm not sure if the Check Markdown links github action has ever ran for this repo
https://github.com/apache/iceberg-python/actions/workflows/check-md-link.yml

@kevinjqliu
Copy link
Contributor Author

kevinjqliu commented Mar 3, 2024

Looks like its related to this
https://stackoverflow.com/questions/61989951/github-action-workflow-not-running

CI and integration test github actions both specifically reference the main branch
https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-ci.yml#L25

We also want this github action to run in pull requests

I can open an issue for this

@kevinjqliu
Copy link
Contributor Author

I just pushed the change following the same format as https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-ci.yml#L25

this PR should now run the check md link github action

@HonahX

@HonahX
Copy link
Contributor

HonahX commented Mar 3, 2024

Thanks for fixing the CI config!

@HonahX HonahX merged commit 3c225a7 into apache:main Mar 3, 2024
7 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/dead-links branch March 4, 2024 00:26
@HonahX HonahX added this to the PyIceberg 0.6.1 milestone Mar 26, 2024
HonahX pushed a commit to HonahX/iceberg-python that referenced this pull request Mar 28, 2024
Fokko added a commit that referenced this pull request Mar 29, 2024
* Github Action to check links in documentation (#324)

* add github add to check md link

* Only run under `mkdocs/**`

* ws

* make lint

---------

Co-authored-by: Fokko Driesprong <[email protected]>

* Fix dead links in docs (#493)
Backport to 0.6.1

---------

Co-authored-by: Kevin Liu <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants