Skip to content

Commit

Permalink
Run Hive3 tests on Java 11 and 17 too (#10482)
Browse files Browse the repository at this point in the history
Project supports building with 8, 11 and 17. In most CI scripts we run
the jobs on all supported Java versions, let's do same here to ensure
the build would work locally too.
  • Loading branch information
findepi authored Jun 19, 2024
1 parent cbd11d7 commit 10d7ab1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/hive-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,17 @@ jobs:
hive3-tests:
runs-on: ubuntu-22.04
strategy:
matrix:
jvm: [8, 11, 17]
env:
SPARK_LOCAL_IP: localhost
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: zulu
java-version: 8
java-version: ${{ matrix.jvm }}
- uses: actions/cache@v4
with:
path: |
Expand Down
13 changes: 5 additions & 8 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,11 @@ if (hiveVersions.contains("2") || hiveVersions.contains("3")) {
project(':hive-runtime').name = 'iceberg-hive-runtime'
}

if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
if (hiveVersions.contains("3")) {
include 'hive3'
include 'hive3-orc-bundle'

project(':hive3').name = 'iceberg-hive3'
project(':hive3-orc-bundle').name = 'iceberg-hive3-orc-bundle'
}
if (hiveVersions.contains("3")) {
include 'hive3'
include 'hive3-orc-bundle'
project(':hive3').name = 'iceberg-hive3'
project(':hive3-orc-bundle').name = 'iceberg-hive3-orc-bundle'
}

include ":iceberg-kafka-connect:kafka-connect-events"
Expand Down

0 comments on commit 10d7ab1

Please sign in to comment.