API: Removes Explicit Parameterization of Schema Tests #11444
+93
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussellSpitzer
commented
Nov 1, 2024
| private static final Map<Type.TypeID, Integer> MIN_FORMAT_VERSIONS = | ||
| ImmutableMap.of(Type.TypeID.TIMESTAMP_NANO, 3); | ||
|
|
||
| private static final Integer MIN_FORMAT_INITIAL_DEFAULT = 3; |
There was a problem hiding this comment.
I think maybe I should just be extracting these from Schema rather than redeclaring them here ...
There was a problem hiding this comment.
My only worry here is we won't catch bugs in bad constants in Schema.java, probably not a real worry
RussellSpitzer
commented
Nov 1, 2024
|
|
||
| private static final Integer MIN_FORMAT_INITIAL_DEFAULT = 3; | ||
|
|
||
| private static final Integer MAX_FORMAT_VERSION = 3; |
There was a problem hiding this comment.
This is a test constant i'd really like to have in just one file somewhere in API, placed here now to demonstrate what I want to do
|
Test results look like |
aihuaxu
approved these changes
Nov 1, 2024
| private static final Map<Type.TypeID, Integer> MIN_FORMAT_VERSIONS = | ||
| ImmutableMap.of(Type.TypeID.TIMESTAMP_NANO, 3); | ||
|
|
||
| private static final Integer MIN_FORMAT_INITIAL_DEFAULT = 3; |
aihuaxu
reviewed
Nov 2, 2024
Fokko
approved these changes
Nov 5, 2024
nastra
reviewed
Nov 6, 2024
nastra
reviewed
Nov 6, 2024
nastra
reviewed
Nov 6, 2024
nastra
reviewed
Nov 6, 2024
nastra
reviewed
Nov 6, 2024
nastra
reviewed
Nov 6, 2024
nastra
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of our tests are currently very specific but are going to be reused for various other types as they get added. We also currently hard code in the versions we are testing. This makes it a little more difficult whenever we add a new format version to correctly update all of the corresponding tests.
I'm updating TestSchema to show what I think should be our general pattern for version specific testing where the versions tested are defined in a single location rather than each time per test.
For the "type" tests, rather than making a named test per type, we parameterize over the type itself so that new types (Geo and Variant) can be added without duplicating code.