Spark 3.5: Preserve data file reference during manifest rewrites #11457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
force-pushed
the
preserve-delete-file-ref-spark
branch
from
e9cbebb
to
277dde2
Compare
nastra
reviewed
Nov 4, 2024
| for (FileScanTask fileTask : tasks) { | ||
| DataFile dataFile = fileTask.file(); | ||
| if (dataFile.location().equals(dataFile1.location())) { | ||
| DeleteFile deleteFile = Iterables.getOnlyElement(fileTask.deletes()); |
There was a problem hiding this comment.
seems like this can be extracted out of the if blocks
nastra
approved these changes
Nov 4, 2024
aokolnychyi
force-pushed
the
preserve-delete-file-ref-spark
branch
from
8074c8f
to
3fc4241
Compare
|
Thanks, @nastra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies Spark to preserve data file reference during manifest rewrites.
This work is part of #11122.