Core: Change Delete granularity to file for new tables #11478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
changed the title
amogh-jahagirdar
force-pushed
the
change-delete-granularity
branch
from
69a8821
to
e4e1f0f
Compare
amogh-jahagirdar
force-pushed
the
change-delete-granularity
branch
from
e4e1f0f
to
95301d5
Compare
amogh-jahagirdar
force-pushed
the
change-delete-granularity
branch
from
95301d5
to
66f8307
Compare
jbonofre
suggested changes
Nov 6, 2024
| @@ -90,6 +90,8 @@ private static Map<String, String> persistedProperties(Map<String, String> rawPr | |||
| persistedProperties.put( | |||
| TableProperties.PARQUET_COMPRESSION, | |||
| TableProperties.PARQUET_COMPRESSION_DEFAULT_SINCE_1_4_0); | |||
| persistedProperties.put( | |||
There was a problem hiding this comment.
By adding this, we need to update a few tests (like Hive), as we see now "write.delete.granularity"="file" in the metadata persistence.
I propose to update the tests.
Maybe worth to add a test to check how to read "previous" files which don't contain the property ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving in this draft since inevitably there will be some CI failures that I need to address due to this default change (some tests work on the assumption of partition granularity deletes)