IGNITE-23885 Start partition in a common manner in case of a single element in chain #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alievmirza
reviewed
Jan 10, 2025
| * @param revision Revision. | ||
| * @return Returns partition assignments from meta storage locally or {@code null} if assignments is absent. | ||
| */ | ||
| public static @Nullable Assignments stableAssignments( |
There was a problem hiding this comment.
Let's name it with "Locally" suffix, or rename tableAssignmentsChainGetLocally. Let's have common naming pattern for "get locally" methods
There was a problem hiding this comment.
Renamed to *GetLocally
| && (pendingAssignments == null || !pendingAssignments.force()); | ||
| AssignmentsChain assignmentsChain = assignmentsChains.get(i); | ||
|
|
||
| if (assignmentsChain == null || assignmentsChain.chain().size() == 1) { |
There was a problem hiding this comment.
Let's add comment describing why assignmentsChain.chain().size() == 1 is a special case and why we have different behaviour instead
There was a problem hiding this comment.
I would refactor this check to a separate method so we could reuse this method in the second place
| * @param revision Revision. | ||
| * @return Future with table assignments as a value. | ||
| */ | ||
| public static List<AssignmentsChain> tableAssignmentsChainGetLocally( |
There was a problem hiding this comment.
Or let's remove locally suffix from here
There was a problem hiding this comment.
Renamed to *GetLocally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23885