pullrequestreview-1972726168

apache · Apr 9, 2024 · 47b06b7 · 47b06b7
1 parent e221a9c
commit 47b06b7
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/HelmSetup.md b/HelmSetup.md
@@ -144,10 +144,11 @@ Some useful parameters for the chart, you could also check them in values.yaml
 
 | Parameter                              | Description                                                                           | Default                  |
 | -------------------------------------- | ------------------------------------------------------------------------------------- | ------------------------ |
-| replicaCount                           | Replica Count for devlake, currently not used                                         | 1                        |
+| replicaCount                           | Replica Count for devlake, currently not used (removed)                               | 1                        |
 | imageTag                               | The version tag for all images                                                        | see Values.yaml          |
 | imagePullSecrets                       | Name of the Secret for accessing private image registries                             | []                       |
 | commonEnvs                             | The common envs for all pods except grafana                                           | {TZ: "UTC"}              |
+| mysql.replicaCount                     | Replica count can only be 0 or 1                                                      | 1                        |
 | mysql.useExternal                      | If use external mysql server, set true                                                | false                    |
 | mysql.externalServer                   | External mysql server address                                                         | 127.0.0.1                |
 | mysql.externalPort                     | External mysql server port                                                            | 3306                     |
@@ -169,6 +170,7 @@ Some useful parameters for the chart, you could also check them in values.yaml
 | mysql.service.type                     | mysql service type                                                                    | ClusterIP                |
 | mysql.service.nodePort                 | specify mysql nodeport                                                                | ""                       |
 | grafana                                | dashboard, datasource, etc. settings for grafana, installed by grafana official chart |                          |
+| lake.replicaCount                      | Replica count can only be 0 or 1                                                      | 1                        |
 | lake.image.repository                  | repository for lake's image                                                           | apache/devlake           |
 | lake.image.pullPolicy                  | pullPolicy for lake's image                                                           | Always                   |
 | lake.port                              | the port of devlake backend                                                           | 8080                     |
@@ -184,6 +186,7 @@ Some useful parameters for the chart, you could also check them in values.yaml
 | lake.livenessProbe                     | container livenessprobe                                                               | see Values.yaml          |
 | lake.readinessProbe                    | container readinessProbe                                                              | see Values.yaml          |
 | lake.deployment.extraLabels            | extra labels for lake's deployment metadata                                           | {}                       |
+| ui.replicaCount                        | Replica count for ui                                                                  | 1                        |
 | ui.image.repository                    | repository for ui's image                                                             | apache/devlake-config-ui |
 | ui.image.pullPolicy                    | pullPolicy for ui's image                                                             | Always                   |
 | ui.basicAuth.enabled                   | If the basic auth in ui is enabled                                                    | false                    |

diff --git a/charts/devlake/templates/deployments.yaml b/charts/devlake/templates/deployments.yaml
@@ -26,7 +26,7 @@ metadata:
     {{- toYaml . | nindent 4 }}
     {{- end }}
 spec:
-  replicas: {{ .Values.replicaCount }}
+  replicas: {{ .Values.ui.replicaCount }}
   {{- with .Values.ui.strategy }}
   strategy:
     {{- toYaml . | nindent 4 }}
@@ -126,7 +126,7 @@ metadata:
   {{- toYaml . | nindent 4 }}
   {{- end }}
 spec:
-  replicas: {{ if gt .Values.replicaCount 1 }}1{{ else }}{{ .Values.replicaCount }}{{ end }}
+  replicas: {{ if gt .Values.lake.replicaCount 1 }}1{{ else }}{{ .Values.lake.replicaCount }}{{ end }}
   {{- with .Values.lake.strategy }}
   strategy:
     {{- toYaml . | nindent 4 }}

diff --git a/charts/devlake/templates/statefulsets.yaml b/charts/devlake/templates/statefulsets.yaml
@@ -25,7 +25,7 @@ metadata:
   labels:
     {{- include "devlake.labels" . | nindent 4 }}
 spec:
-  replicas: {{ .Values.replicaCount }}
+  replicas: {{ if gt .Values.mysql.replicaCount 1 }}1{{ else }}{{ .Values.mysql.replicaCount }}{{ end }}
   serviceName: {{ include "devlake.fullname" . }}-mysql
   selector:
     matchLabels:

diff --git a/charts/devlake/values.yaml b/charts/devlake/values.yaml
@@ -15,8 +15,8 @@
 # limitations under the License.
 #
 
-# replica count
-replicaCount: 1
+# global replica count was removed
+
 imageTag: v1.0.0-beta3
 
 # image pull secrets
@@ -27,6 +27,7 @@ commonEnvs:
   TZ: "UTC"
 
 mysql:
+  replicaCount: 1
   # if use external mysql server, please set true
   # by default using false, chart will create a single mysql instance
   useExternal: false
@@ -168,6 +169,7 @@ grafana:
   ingressServicePort: ""
 
 lake:
+  replicaCount: 1
   image:
     repository: devlake.docker.scarf.sh/apache/devlake
     pullPolicy: Always
@@ -242,6 +244,7 @@ lake:
     extraLabels: {}
 
 ui:
+  replicaCount: 1
   image:
     repository: devlake.docker.scarf.sh/apache/devlake-config-ui
     pullPolicy: Always