Skip to content

Commit

Permalink
feat: add liveness and readiness probe for ui
Browse files Browse the repository at this point in the history
Closes #227
  • Loading branch information
Ronny Bräunlich committed Jan 11, 2024
1 parent ba09914 commit 86ab1f7
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 0 deletions.
2 changes: 2 additions & 0 deletions HelmSetup.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ Some useful parameters for the chart, you could also check them in values.yaml
| ui.extraLabels | extra labels for ui's statefulset | {} |
| ui.securityContext | pod security context values | {} |
| ui.containerSecurityContext | container security context values | {} |
| ui.livenessProbe | container livenessprobe | see Values.yaml |
| ui.readinessProbe | container readinessProbe | {} |
| service.type | Service type for exposed service | NodePort |
| service.uiPort | Node port for config ui | 32001 |
| service.ingress.enabled | If enable ingress | false |
Expand Down
8 changes: 8 additions & 0 deletions charts/devlake/templates/deployments.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ spec:
imagePullPolicy: {{ .Values.ui.image.pullPolicy }}
ports:
- containerPort: 4000
{{- with .Values.ui.livenessProbe }}
livenessProbe:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.ui.readinessProbe }}
readinessProbe:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if .Values.ui.basicAuth.enabled }}
envFrom:
- secretRef:
Expand Down
9 changes: 9 additions & 0 deletions charts/devlake/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,15 @@ ui:
# capabilities:
# drop:
# - all
livenessProbe:
httpGet:
path: /
port: 4000
scheme: HTTP
initialDelaySeconds: 60
timeoutSeconds: 30

readinessProbe: { }

# alpine image for some init containers
alpine:
Expand Down

0 comments on commit 86ab1f7

Please sign in to comment.