-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initContainer in statefulsets and values #196
Conversation
Hi @ProjectsOfMLee, you need to make so the default value generates the same result that you had before your change. I see in your commits this is what you did, so that’s perfect. A part from that, you do need to add the initContainert to the HelmSetup.md. |
Thanks! I have added it to the .md |
Great! I’m checking with my phone, but it seems like the tabulation/number-of-spaces is different from the rest. Could you kindly double-check and make sure it’s the same? It’s a silly thing, but it makes future reviews easier. The rest of the PR looks good to me 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have adjusted the tabs. Thank you :) |
Can we get this into a beta release, please? We are eagerly anticipating this to be available soon! Thanks @JorgeGar, @ProjectsOfMLee and team! |
LGTM |
@JorgeGar Do I need to also add the specific initContainer configs solution to #194 to this PR or leave it customizable as is?