Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ability to leverage basic annotations #198

Merged
merged 2 commits into from
Nov 13, 2023
Merged

adding ability to leverage basic annotations #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79c3eb2
adding ability to leverage basic annotations
adamwolfe-tc Nov 9, 2023
9358cc6
updated terminology per maintainer request
adamwolfe-tc Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/devlake/templates/deployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ spec:
{{- with .Values.ui.extraLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
annotations:
{{- toYaml .Values.ui.podAnnotations | nindent 8 }}
spec:
{{- with .Values.ui.securityContext }}
securityContext:
Expand Down Expand Up @@ -113,6 +115,8 @@ spec:
{{- with .Values.lake.extraLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
annotations:
{{- toYaml .Values.lake.podAnnotations | nindent 8 }}
spec:
{{- with .Values.lake.securityContext }}
securityContext:
Expand Down
2 changes: 2 additions & 0 deletions charts/devlake/templates/statefulsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ spec:
{{- with .Values.mysql.extraLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
annotations:
{{- toYaml .Values.mysql.podAnnotations | nindent 8 }}
spec:
{{- with .Values.mysql.securityContext }}
securityContext:
Expand Down
8 changes: 8 additions & 0 deletions charts/devlake/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ mysql:

containerSecurityContext: {}

podAnnotations: {}

adamwolfe-tc marked this conversation as resolved.
Show resolved Hide resolved
service:
type: "ClusterIP"
nodePort: ""
Expand Down Expand Up @@ -135,6 +137,8 @@ mysql:

# containerSecurityContext: {}

# annotations: {}

# dependency chart values
grafana:
enabled: true
Expand Down Expand Up @@ -200,6 +204,8 @@ lake:

containerSecurityContext: {}

podAnnotations: {}

adamwolfe-tc marked this conversation as resolved.
Show resolved Hide resolved
ui:
image:
repository: devlake.docker.scarf.sh/apache/devlake-config-ui
Expand All @@ -223,6 +229,8 @@ ui:

extraLabels: {}

podAnnotations: {}

adamwolfe-tc marked this conversation as resolved.
Show resolved Hide resolved
## SecurityContext holds pod-level security attributes and common container settings.
## This defaults to non root user with uid 101 and gid 1000. *v1.PodSecurityContext false
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
Expand Down
Loading