Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Grafana ingress and containerSecurity #199

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: Grafana ingress and containerSecurity #199

merged 3 commits into from
Nov 13, 2023

Conversation

koendelaat
Copy link
Contributor

@koendelaat koendelaat commented Nov 10, 2023 •
edited
Loading

Two issues I ran into while using the chart

@d4x1
Copy link
Contributor

d4x1 commented Nov 12, 2023

@ZhangNing10 Please help to review it.

ZhangNing10
ZhangNing10 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ZhangNing10 ZhangNing10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 56dd5a5 into apache:main Nov 13, 2023
3 checks passed
@koendelaat koendelaat deleted the chore/patches branch November 13, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhangNing10 ZhangNing10 ZhangNing10 approved these changes

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koendelaat @d4x1 @klesh @ZhangNing10