Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace submodules by GitHub actions #201

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Replace submodules by GitHub actions #201

merged 1 commit into from
Nov 15, 2023

Conversation

koendelaat
Copy link
Contributor

Currently Helm release builds are failing due to submodules problems

This PR addresses this by replacing the submodules by direct action references

@koendelaat
Copy link
Contributor Author

@ZhangNing10 I noticed that you released version 0.19.1-beta1 a few hours ago.
The charts are however not published on GitHub Pages due to some errors. This PR addresses this issue

ZhangNing10
ZhangNing10 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@ZhangNing10 ZhangNing10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 6183a25 into apache:main Nov 15, 2023
1 check passed
@klesh
Copy link
Contributor

klesh commented Nov 15, 2023

@koendelaat Thanks for your contribution.

klesh added a commit that referenced this pull request Nov 15, 2023
@klesh
Revert "Replace submodules by GitHub actions (#201)"
90674af 
This reverts commit 6183a25.
@klesh
Copy link
Contributor

klesh commented Nov 15, 2023

Oh, no. we can not use Github Actions from 3rd parties. We have to revert it

ZhangNing10 added a commit to ZhangNing10/incubator-devlake-helm-chart that referenced this pull request Nov 15, 2023
@ZhangNing10
Revert "Replace submodules by GitHub actions (apache#201)"
57d1bfc 
This reverts commit 6183a25.
@ZhangNing10 ZhangNing10 mentioned this pull request Nov 15, 2023
Merged
klesh pushed a commit that referenced this pull request Nov 15, 2023
@ZhangNing10
Revert "Replace submodules by GitHub actions (#201)" (#203)
34ca54b 
This reverts commit 6183a25.
@koendelaat
Copy link
Contributor Author

koendelaat commented Nov 15, 2023 •
edited
Loading

Oh, no. we can not use Github Actions from 3rd parties. We have to revert it

@klesh just wondering why you cannot use 3rd party actions?
Also why is using the same action but with a submodule reference OK?

Maybe good to include this rationale in your CONTRIBUTION section

@klesh
Copy link
Contributor

klesh commented Nov 15, 2023

@koendelaat Not that I DON'T want to. In fact, it would make my life much easier if I'm allowed to use 3rd party actions. It is the Apache policy.
Note that the repository belongs to Apache Foundation, Not me...🥲

@ZhangNing10 ZhangNing10 mentioned this pull request Feb 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhangNing10 ZhangNing10 ZhangNing10 approved these changes

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koendelaat @klesh @ZhangNing10