fix: use pathType ImplementationSpecific for regex

[guilhem]

fix error

path /(/?|$)(.*) cannot be used with pathType Prefix

[klesh]

@JorgeGar Would you like to take a look? Thanks in advance.

[guilhem]

gentle ping

[JorgeGar]

This should be good enough, but why not making the pathType itself a variable?

[guilhem]

in fact, I just copy paste exactly what was working before:

              {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
              service:
                name: {{ .Values.grafana.ingressServiceName | default ( include "grafana.fullname" (dict "Values" .Values.grafana "Chart" (dict "Name" "grafana") "Release" .Release ) ) }}
                port:
                  number: {{ .Values.grafana.ingressServicePort | default .Values.grafana.service.port }}
              {{- else }}
              serviceName: {{ .Values.grafana.ingressServiceName | default ( include "grafana.fullname" (dict "Values" .Values.grafana "Chart" (dict "Name" "grafana") "Release" .Release ) ) }}
              servicePort: {{ .Values.grafana.ingressServicePort | default .Values.grafana.service.port }}
              {{- end }}

[JorgeGar]

gentle ping

So sorry, I missed the first notifications. Thanks for the ping.
I've added one comment, just let me know what you think about that :)

[guilhem]

@JorgeGar I change in last commit the way to manage ingress with 2 different ing resources.
I think it's easier to manage annotations specific in this way.

I also have that need because (/?|$)(.*) was far too much aggressive when wanting to do specific configuration for sub path (I have special rules for /api).

[JorgeGar]

I don't think we have the value garafana.service.port in the values.yaml file. Since this is the default, coul you kindly add it?

[JorgeGar]

@guilhem if you could kindly take a look into this, the rest is looking great and I'm happy to approve it :)

[guilhem]

@JorgeGar I replied here #272 (comment)

[JorgeGar]

All good then :) Thanks

[guilhem]

I kept the exact same behavior not to change everything at once :)

Theses values come from grafana chart as dependancy.

[ZhangNing10]

hi @guilhem @JorgeGar , i have to revert this pr as having two ingresses can result in waste when the ingress class is alb, it would create two aws alb, i have created a pr #278 for this issue, could you check whether this pr solves your issue?

[guilhem]

hi @guilhem @JorgeGar , i have to revert this pr as having two ingresses can result in waste when the ingress class is alb, it would create two aws alb, i have created a pr #278 for this issue, could you check whether this pr solves your issue?

Hi @ZhangNing10 this is not the case since 2020 and controller v2: https://aws.amazon.com/fr/blogs/containers/introducing-aws-load-balancer-controller/

you can use:

metadata:
  annotation:
    alb.ingress.kubernetes.io/group.name: devlake

which is supported by this PR as we are sharing the same .Values.ingress.annotations for both ingresses :)

[ZhangNing10]

hi @guilhem @JorgeGar , i have to revert this pr as having two ingresses can result in waste when the ingress class is alb, it would create two aws alb, i have created a pr #278 for this issue, could you check whether this pr solves your issue?

Hi @ZhangNing10 this is not the case since 2020 and controller v2: https://aws.amazon.com/fr/blogs/containers/introducing-aws-load-balancer-controller/

you can use:

metadata:
  annotation:
    alb.ingress.kubernetes.io/group.name: devlake

which is supported by this PR as we are sharing the same .Values.ingress.annotations for both ingresses :)

Hi @guilhem , thanks for the info! As the grafana specifies root_url: "%(protocol)s://%(domain)s/grafana" with a subpath grafana, so i think for internal grafana, no need to rewrite target, while for an external grafana, rewrite target should be needed. So, i removed the rewrite target path for the first ingress, could you help review the pr #278 and check whether it includes the fix of the issue you found?

[JorgeGar]

hi @guilhem @JorgeGar , i have to revert this pr as having two ingresses can result in waste when the ingress class is alb, it would create two aws alb, i have created a pr #278 for this issue, could you check whether this pr solves your issue?

Hi @ZhangNing10 this is not the case since 2020 and controller v2: https://aws.amazon.com/fr/blogs/containers/introducing-aws-load-balancer-controller/
you can use:

metadata:
  annotation:
    alb.ingress.kubernetes.io/group.name: devlake

which is supported by this PR as we are sharing the same .Values.ingress.annotations for both ingresses :)

Hi @guilhem , thanks for the info! As the grafana specifies root_url: "%(protocol)s://%(domain)s/grafana" with a subpath grafana, so i think for internal grafana, no need to rewrite target, while for an external grafana, rewrite target should be needed. So, i removed the rewrite target path for the first ingress, could you help review the pr #278 and check whether it includes the fix of the issue you found?

Hi @ZhangNing10. Sorry, I was a bit late to answer. I see the PR is already merged. Is the issue solved? Please, let me know how else I can help 😃

[ghost]

Hi @guilhem,

Thank you for your contribution! I'm Joshua Poddoku, Committer at Apache DevLake. We'd love for you to join our Slack community or DM me incase you've joined already: https://join.slack.com/t/devlake-io/shared_invite/zt-18uayb6ut-cHOjiYcBwERQ8VVPZ9cQQw. Could you please share your full name there? We want to recognize your efforts with a certificate of contribution.

Best,
Joshua