Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable option to add Volume, VolumeMount to devlake Deployment - critical for SSL certificate #311

Conversation

GuillermoGarciaF
Copy link
Contributor

The devlake Deployment does not expose Volumes, VolumeMounts.

These are required e.g. to mount a CA Certificate to establish a secure SSL connection.
Our policies only allow SSL connections to Azure MySQL Server. I would love to contribute to Apache DevLAke and add the PR myself.

There are several GH issues related to SSL and the current limitations

See #310

@GuillermoGarciaF
Copy link
Contributor Author

CC: @abeizn @ZhangNing10 please review

@klesh
Copy link
Contributor

klesh commented Oct 21, 2024

Nice work, have you tested it on your local env?

@GuillermoGarciaF
Copy link
Contributor Author

Yes, I successfully tested the following helm-values:

lake:
  volumeMounts:
    - name: azure-mysql-ca
      mountPath: /opt/argus/DigiCertGlobalRootCA.crt.pem
      subPath: DigiCertGlobalRootCA.crt.pem
      readOnly: true
  volumes:
    - name: azure-mysql-ca
      configMap:
        name: azure-mysql-ca
        items:
        - key: DigiCertGlobalRootCA.crt.pem
          path: DigiCertGlobalRootCA.crt.pem

which result in the following pod manifest:

-volumes: section:
Screenshot 2024-10-21 at 08 40 14

-volumeMounts: section:
Screenshot 2024-10-21 at 08 41 32

I also checked the certificate is correctly mounted in the container file system:
Screenshot 2024-10-21 at 08 47 12

@GuillermoGarciaF
Copy link
Contributor Author

Finally, I confirmed the devlake container stablishes SSL connection when concatenating &tls=custom&ca-cert=/opt/argus/DigiCertGlobalRootCA.crt.pem in the DB_URL environment variable.

@klesh klesh merged commit e87339b into apache:main Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants