-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-8479][CORE][Part-1] Remove unnecessary config #8480
Conversation
Run Gluten ClickHouse CI on ARM |
@jackylee-ch @baibaichen Could you please take a look, thanks! |
Run Gluten ClickHouse CI on ARM |
1 similar comment
Run Gluten ClickHouse CI on ARM |
8e3c174
to
a1bc64a
Compare
Run Gluten ClickHouse CI on ARM |
a1bc64a
to
c28ccef
Compare
Run Gluten ClickHouse CI on ARM |
1 similar comment
Run Gluten ClickHouse CI on ARM |
please add the removed configs in PR description. |
added, thanks! |
Run Gluten ClickHouse CI on ARM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! left one comment.
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala
Outdated
Show resolved
Hide resolved
533132b
to
65543fc
Compare
Run Gluten ClickHouse CI on ARM |
Run Gluten ClickHouse CI on ARM |
Run Gluten Clickhouse CI on x86 |
@@ -93,7 +93,6 @@ object RunTPCHTest { | |||
.config("spark.databricks.delta.snapshotPartitions", 1) | |||
.config("spark.databricks.delta.properties.defaults.checkpointInterval", 5) | |||
.config("spark.databricks.delta.stalenessLimit", 3600 * 1000) | |||
.config("spark.gluten.sql.columnar.columnarToRow", columnarColumnToRow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could remove the variable definition if unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They has be removed in this pr. see GlutenConfig change
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Fix #8479, This PR removed some unused configurations and methods for getting configurations. The removed configurations are as follows:
How was this patch tested?
GA.