This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add ability to simulate streamlet topologies #2712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support in both the streamlet and topology apis for the usage of custom eviction policies extending com.twitter.heron.api.windowing.EvictionPolicy and trigger policies extending com.twitter.heron.api.windowing.TriggerPolicy to enable user-defined windowing schemes.
Fixed Checkstyle Issues
…utor to require both Policies to be provided if one of them is
…ush then pull clean copy)
…ndowManager, Config object, TriggerHandler and EvictionPolicy
…ning "started" again for CountTriggerPolicy
|
Thanks for the PR. Reviewing it. |
|
@dancollins34 - can you please remove the dependency and update the PR as we discussed? |
|
Reverted the changes and made a new pr which puts an interface under heronSubmitter and TopologySimulator |
|
@dancollins34 - it will be nice to add some docs on how to run streamlets in simulation mode. it will be very useful for the user. |
|
@dancollins34 So are we not able to simulate Streamlets without this change? Are there any examples of how to simulate a Streamlet? I know this is a super old PR, but I'd like to resolve these conflicts and merge in. Are there any examples of how to simulate a Streamlet? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the few changes required to enable simulation of streamlet topologies