first checkin for heron ml #2978
Conversation
There was a problem hiding this comment.
Thank you very much for the contribution. Several general comments:
-
The ml related code should be under the
heron-mldirectory in the repo's root directory. Just likeheronpy,eco,examples,integrationandstorm-compatibility. -
The root package path should be
org.apache.heron.ml. The detailed comment are in the following code review. -
Please make sure it can be compiled and run correctly (add BUILD files, resolving dependencies and do some basic unit test or functional test) before merging this PR.
| import org.slf4j.LoggerFactory; | ||
| import org.apache.commons.configuration.Configuration; | ||
|
|
||
| import backtype.storm.Config; |
There was a problem hiding this comment.
We should use org.apache.heron.Config instead of the backtype.storm.Config. And for any following files should be the same case.
| @@ -0,0 +1,82 @@ | |||
| package org.apache.heron; | |||
There was a problem hiding this comment.
the package path should be org.apache.heron.ml if it's a general class needed by all machine learning runtime. If it's specific for samoa, then the package path should be org.apache.heron.ml.samoa.
And this also applies to all the following files.
Brought over all the ml code from samoa as is without building anything, this will serve as a starting point