-
Notifications
You must be signed in to change notification settings - Fork 594
Upgrade WORKSPACE python packages for python3.8 support #3646
Conversation
9346d24
to
b3583c0
Compare
Looks good. What else is needed to remove from draft status? |
@Code0x58 What do we need to do to pick up work on this branch? Anything I can help with? |
I think with these changes the python version in Travis blows up, or image (tested via I can't recall what specifically required a change from 3.6 to something higher - probably just the newer libraries that work with 3.9. One path forward is to upgrade all the python versions installed in the container images+CI (Travis + Ubuntu vagrant manifests) to some minimum version - you could use pyenv in the Vagrant machine to find what the lowest working version is. This would be a bit of a pain due to the multiple runtimes required to use Heron, so can't just use pre-existing base images (I think the JRE may be the first class citizen for that in the images). It's not a particularly appealing change, especially considering it may force python tennants to try upgrading their code+dependencies, but it's probably a reasonable thing to do without reconsidering the whole architecture or trying stick with Python 3.6-3.8 only. |
I am wondering which module uses more libraries? It might be ideal to
minimize the use of extra libraries considering the compatibility issues
with Python.
…On Wed, Feb 3, 2021 at 6:08 PM Oliver Bristow ***@***.***> wrote:
I think with these changes the python version in Travis blows up, or image
(tested via ./scripts/release/build-images --all) having versions that
blow up during the build.
I can't recall what specifically required a change from 3.6 to something
higher - probably just the newer libraries that work with 3.9.
One path forward is to upgrade all the python versions installed in the
container images+CI (Travis + Ubuntu vagrant manifests) to some minimum
version - you could use pyenv in the Vagrant machine to find what the
lowest working version is. This would be a bit of a pain due to the
multiple runtimes required to use Heron, so can't just use pre-existing
base images (I think the JRE may be the first class citizen for that in the
images). It's not a particularly appealing change, especially considering
it may force python tennants to try upgrading their code+dependencies, but
it's probably a reasonable thing to do without reconsidering the whole
architecture or trying stick with Python 3.6-3.8 only.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3646 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQPBH65RSR76W5H75LRT6DS5H6RTANCNFSM4USEOSQQ>
.
|
TODO: * add container methods+views * add metrics methods+views * sort out typing * sort out return evelope stuff * sort out tests * add exception hierarchy and give traceback dev issues
TODO: * move Tracker.pb2_to_api stuff to Topology and update object necissary
c9dd9c9
to
9f1a612
Compare
…/incubator-heron into upgrade-py-dependencies # Conflicts: # heron/tools/explorer/src/python/BUILD # heron/tools/tracker/src/python/BUILD # heron/tools/tracker/src/python/utils.py # heron/tools/tracker/tests/python/BUILD
#3642 Code was integrated into this PR. Tracker Behavior changes:
|
This upgrades a few python packages. One benefit is that infrastructure/tests work on python3.9 (due to upgrading pex to a version that says it can be installed in python <=3.9) so will fix the issue seen in #3638