This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add tagged metric support in MetricsCollector #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwangtw
force-pushed
the
add_tagged_metric_support
branch
from
c816a7f to
01d1058
Compare
|
@nwangtw is this ready to be reviewed? |
|
I think it would be good to do prometheus Labels. |
|
Not yet. Got some feedbacks during the meetup and I need to think about it
more.
…On Sun, Feb 13, 2022 at 7:35 PM choi se ***@***.***> wrote:
@nwangtw <https://github.com/nwangtw> , @joshfischer1108
<https://github.com/joshfischer1108>
I think it would be good to do prometheus Labels.
https://prometheus.io/docs/practices/naming/#labels
—
Reply to this email directly, view it on GitHub
<#3750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQPBH43YSO6JPCRV7LPXNTU3B2AVANCNFSM5KLYYQXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
nwangtw
force-pushed
the
add_tagged_metric_support
branch
from
01d1058 to
1b2bf3a
Compare
|
@nwangtw do we plan to do anymore work on this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support tags in metrics protobuf and collector.