Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DROOLS-7581] Fix kie-benchmarks GHA : Could not find artifact org.dr… #272

Closed
wants to merge 1 commit into from

Conversation

tkobayas
Copy link
Contributor

…ools:drools-reliability-h2mvstore:jar:8.45.0-SNAPSHOT

…ools:drools-reliability-h2mvstore:jar:8.45.0-SNAPSHOT
@hellowdan
Copy link
Contributor

@skulisek please take a look

@skulisek
Copy link

LGTM, I wasn't sure if adding repositories was an option or just a workaround so I didn't suggest it.

@tkobayas
Copy link
Contributor Author

tkobayas commented Oct 27, 2023

Hi @baldimir ! I think we need to involve you here.

I have just noticed that this PR (Adding repository.jboss.org) is opposite to our apache migration direction.

With kie-issues#628, we are going to release snapshot Maven artifacts to Apache Nexus instead of JBoss Nexus.

Indeed, the referenced repository in kie-benchmarks was changed from jboss to apache with this PR.
#267

However, the snapshot release to apache is not yet done, so kie-benchmarks fails to build at the moment.

https://issues.apache.org/jira/browse/INFRA-25077
-> According to the comments, it's really in progress and it may complete in a few days.

https://repository.apache.org/content/groups/public/
-> https://repository.apache.org/content/groups/public/org/drools returns 404 at the moment.

Interestingly, kie-benchmarks failed since it introduced a new dependency org.drools:drools-reliability-h2mvstore:jar:8.45.0-SNAPSHOT. Other SNAPSHOT dependencies worked thanks to GHA action "cache" actions/cache@v2 configured in pull_request.yml.

@baldimir , is it okay to merge this PR (Adding repository.jboss.org) as a temporal workaround until actually snapshot artifacts will be released in apache repo? Once snapshots are released in apache repo, I will remove the jboss repo reference.

@tkobayas tkobayas requested a review from baldimir October 27, 2023 02:20
@baldimir
Copy link
Contributor

I personally don't agree with merging this as we will be releasing snapshost to Apache Nexus soon. If the build fails somewhere, I would suggest to please use a custom settings.xml file. Sorry for this, we are working to get the snapshots released as soon as possible.

@tkobayas
Copy link
Contributor Author

@baldimir Thank you for the reply. It's okay for me to close this PR. We can run benchmarks locally.

@tkobayas tkobayas closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants