-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[KOGITO-5777] Centralize data type resolution (#1579)
- Loading branch information
Showing
7 changed files
with
166 additions
and
140 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
jbpm/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/DataTypeResolver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /* | ||
| * Copyright 2021 Red Hat, Inc. and/or its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.jbpm.process.core.datatype; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Map.Entry; | ||
| import java.util.Optional; | ||
|
|
||
| import org.jbpm.process.core.datatype.impl.type.BooleanDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.EnumDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.FloatDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.IntegerDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.ListDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.ObjectDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.StringDataType; | ||
|
|
||
| public class DataTypeResolver { | ||
|
|
||
| public static final DataType defaultDataType = new ObjectDataType("java.lang.Object"); | ||
|
|
||
| private static final Map<Class<?>, DataType> dataTypes = new HashMap<>(); | ||
|
|
||
| static { | ||
| dataTypes.put(Boolean.class, new BooleanDataType()); | ||
| dataTypes.put(String.class, new StringDataType()); | ||
| dataTypes.put(Integer.class, new IntegerDataType()); | ||
| dataTypes.put(Float.class, new FloatDataType()); | ||
| dataTypes.put(Collection.class, new ListDataType()); | ||
| dataTypes.put(Enum.class, new EnumDataType()); | ||
| } | ||
|
|
||
| private DataTypeResolver() { | ||
| } | ||
|
|
||
| public static DataType fromType(String type, ClassLoader cl) { | ||
| return type == null ? defaultDataType : from(type, cl); | ||
| } | ||
|
|
||
| public static DataType fromObject(Object value) { | ||
| return value == null ? defaultDataType : from(value.getClass()).orElse(buildObjectDataType(value.getClass().getCanonicalName())); | ||
| } | ||
|
|
||
| private static DataType from(String type, ClassLoader cl) { | ||
| if (!type.contains(".")) { | ||
| type = "java.lang." + type; | ||
| } | ||
| try { | ||
| return from(cl.loadClass(type)).orElse(new ObjectDataType(type, cl)); | ||
| } catch (ClassNotFoundException ex) { | ||
| return new ObjectDataType(type); | ||
| } | ||
| } | ||
|
|
||
| private static Optional<DataType> from(Class<?> type) { | ||
| for (Entry<Class<?>, DataType> entry : dataTypes.entrySet()) { | ||
| if (entry.getKey().isAssignableFrom(type)) { | ||
| return Optional.of(entry.getValue()); | ||
| } | ||
| } | ||
| return Optional.empty(); | ||
| } | ||
|
|
||
| private static DataType buildObjectDataType(String type) { | ||
| try { | ||
| Class.forName(type); | ||
| return new ObjectDataType(type); | ||
| } catch (ClassNotFoundException ex) { | ||
| return defaultDataType; | ||
| } | ||
| } | ||
| } |
58 changes: 58 additions & 0 deletions
58
jbpm/jbpm-flow/src/test/java/org/jbpm/process/core/datatype/DataTypeResolverTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| * Copyright 2021 Red Hat, Inc. and/or its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.jbpm.process.core.datatype; | ||
|
|
||
| import java.util.Arrays; | ||
|
|
||
| import org.jbpm.process.core.datatype.impl.type.BooleanDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.EnumDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.FloatDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.IntegerDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.ListDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.ObjectDataType; | ||
| import org.jbpm.process.core.datatype.impl.type.StringDataType; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| public class DataTypeResolverTest { | ||
|
|
||
| private enum Champions { | ||
| BETIS, | ||
| DEPORTIVO, | ||
| REAL_SOCIEDAD, | ||
| VALENCIA | ||
| } | ||
|
|
||
| @Test | ||
| public void testDataType() { | ||
| ClassLoader cl = Thread.currentThread().getContextClassLoader(); | ||
| assertTrue(DataTypeResolver.fromObject("pepe") instanceof StringDataType); | ||
| assertTrue(DataTypeResolver.fromObject(true) instanceof BooleanDataType); | ||
| assertTrue(DataTypeResolver.fromObject(4) instanceof IntegerDataType); | ||
| assertTrue(DataTypeResolver.fromObject(23.2f) instanceof FloatDataType); | ||
| assertTrue(DataTypeResolver.fromObject(Arrays.asList("1", "2", "3")) instanceof ListDataType); | ||
| assertTrue(DataTypeResolver.fromObject(new byte[0]) instanceof ObjectDataType); | ||
| assertTrue(DataTypeResolver.fromObject(Champions.BETIS) instanceof EnumDataType); | ||
| assertTrue(DataTypeResolver.fromType("String", cl) instanceof StringDataType); | ||
| assertTrue(DataTypeResolver.fromType("Boolean", cl) instanceof BooleanDataType); | ||
| assertTrue(DataTypeResolver.fromType("Integer", cl) instanceof IntegerDataType); | ||
| assertTrue(DataTypeResolver.fromType("Float", cl) instanceof FloatDataType); | ||
| assertTrue(DataTypeResolver.fromType("java.util.List", cl) instanceof ListDataType); | ||
| assertTrue(DataTypeResolver.fromType("Object", cl) instanceof ObjectDataType); | ||
|
|
||
| } | ||
| } |
Oops, something went wrong.