[kie-issues-249] Data Index Events changes for allowing historical data #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
changed the title
porcelli
previously requested changes
Sep 20, 2023
elguardian
force-pushed
the
kie-issues-249
branch
2 times, most recently
from
cbd7988 to
60a1312
Compare
elguardian
force-pushed
the
kie-issues-249
branch
2 times, most recently
from
c6a354d to
039edf0
Compare
elguardian
force-pushed
the
kie-issues-249
branch
2 times, most recently
from
c3ea924 to
ca4dbfb
Compare
pefernan
reviewed
Sep 28, 2023
| assertThat(body.getNodeInstances()).extractingResultOf("getTriggerTime").allMatch(v -> v != null); | ||
| assertThat(body.getNodeInstances()).extractingResultOf("getLeaveTime").allMatch(v -> v != null); | ||
|
|
||
| assertProcessInstanceEvent(events.get(3), "UserTasksProcess", "UserTasksProcess", 2); |
There was a problem hiding this comment.
@elguardian this test is failing here... I can fix it with this:
Suggested change
| assertProcessInstanceEvent(events.get(3), "UserTasksProcess", "UserTasksProcess", 2); | |
| assertNodeInstanceEvent(events.get(3), processInstance.id(), "End Event 1", 1); |
pefernan
approved these changes
Sep 29, 2023
|
build now |
elguardian
force-pushed
the
kie-issues-249
branch
from
ca4dbfb to
19e8f03
Compare
elguardian
force-pushed
the
kie-issues-249
branch
from
19e8f03 to
7eb486a
Compare
|
build now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: apache/incubator-kie-issues#249
depends on apache/incubator-kie-drools#5529