Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.guava:guava from 29.0-jre to 32.0.0-jre in /.ci/jenkins/tests #3262

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2023

Bumps com.google.guava:guava from 29.0-jre to 32.0.0-jre.

Release notes

Sourced from com.google.guava:guava's releases.

32.0.0

Maven

<dependency>
  <groupId>com.google.guava</groupId>
  <artifactId>guava</artifactId>
  <version>32.0.0-jre</version>
  <!-- or, for Android: -->
  <version>32.0.0-android</version>
</dependency>

Jar files

Guava requires one runtime dependency, which you can download here:

Javadoc

JDiff

Changelog

Security fixes

While CVE-2020-8908 was officially closed when we deprecated Files.createTempDir in Guava 30.0, we've heard from users that even recent versions of Guava have been listed as vulnerable in other databases of security vulnerabilities. In response, we've reimplemented the method (and the very rarely used FileBackedOutputStream class, which had a similar issue) to eliminate the insecure behavior entirely. This change could technically affect users in a number of different ways (discussed under "Incompatible changes" below), but in practice, the only problem users are likely to encounter is with Windows. If you are using those APIs under Windows, you should skip 32.0.0 and go straight to 32.0.1 which fixes the problem. (Unfortunately, we didn't think of the Windows problem until after the release. And while we warn that common.io in particular may not work under Windows, we didn't intend to regress support.) Sorry for the trouble.

Incompatible changes

Although this release bumps Guava's major version number, it makes no binary-incompatible changes to the guava artifact.

One change could cause issues for Widows users, and a few other changes could cause issues for users in more usual situations:

  • The new implementations of Files.createTempDir and FileBackedOutputStream throw an exception under Windows. This is fixed in 32.0.1. Sorry for the trouble.
  • guava-gwt now requires GWT 2.10.0.
  • This release makes a binary-incompatible change to a @Beta API in the separate artifact guava-testlib. Specifically, we changed the return type of TestingExecutors.sameThreadScheduledExecutor to ListeningScheduledExecutorService. The old return type was a package-private class, which caused the Kotlin compiler to produce warnings. (dafaa3e435)

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 25, 2023
@elguardian elguardian self-requested a review October 25, 2023 09:52
Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pefernan
Copy link
Contributor

@elguardian @fjtirado shouldn't we use 32.0.1 As in #3113 and skip this PR?

@fjtirado
Copy link
Contributor

@elguardian @fjtirado shouldn't we use 32.0.1 As in #3113 and skip this PR?

I think we should just remove the line from this POM

@jomarko
Copy link
Contributor

jomarko commented Oct 25, 2023

@fjtirado may we ask you to backport #3113 into https://github.com/apache/incubator-kie-kogito-runtimes/tree/1.40.x branch ?

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 25, 2023

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3262 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3262/1/display/redirect

Test results:

  • PASSED: 3387
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.serverless.workflow.deployment.livereload.LiveReloadProcessorTest.testGrpc 1 expectation failed.
Expected status code <201> but was <500>.

@fjtirado
Copy link
Contributor

fjtirado commented Oct 25, 2023

@fjtirado may we ask you to backport #3113 into https://github.com/apache/incubator-kie-kogito-runtimes/tree/1.40.x branch ?

#3265

@yesamer
Copy link
Contributor

yesamer commented Jan 17, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/dot-ci/jenkins/tests/com.google.guava-guava-32.0.0-jre branch from dacc475 to b6d8b58 Compare January 17, 2024 14:27
@yesamer
Copy link
Contributor

yesamer commented Jan 24, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/dot-ci/jenkins/tests/com.google.guava-guava-32.0.0-jre branch from b6d8b58 to 950ac56 Compare January 24, 2024 20:42
@yesamer
Copy link
Contributor

yesamer commented Feb 21, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/dot-ci/jenkins/tests/com.google.guava-guava-32.0.0-jre branch from 950ac56 to 2d1f5ef Compare February 21, 2024 08:53
@yesamer yesamer closed this Mar 18, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 18, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/dot-ci/jenkins/tests/com.google.guava-guava-32.0.0-jre branch March 18, 2024 09:23
@yesamer yesamer restored the dependabot/maven/dot-ci/jenkins/tests/com.google.guava-guava-32.0.0-jre branch March 18, 2024 09:27
@yesamer yesamer reopened this Mar 18, 2024
@yesamer
Copy link
Contributor

yesamer commented Mar 18, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/dot-ci/jenkins/tests/com.google.guava-guava-32.0.0-jre branch from 2d1f5ef to 05aa8b0 Compare March 18, 2024 09:28
@yesamer
Copy link
Contributor

yesamer commented Apr 16, 2024

https://github.com/dependabot rebase

Bumps [com.google.guava:guava](https://github.com/google/guava) from 29.0-jre to 32.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/dot-ci/jenkins/tests/com.google.guava-guava-32.0.0-jre branch from 05aa8b0 to 22f13bd Compare April 16, 2024 06:48
@yesamer yesamer merged commit 2c9b5e4 into main Apr 22, 2024
3 checks passed
@dependabot dependabot bot deleted the dependabot/maven/dot-ci/jenkins/tests/com.google.guava-guava-32.0.0-jre branch April 22, 2024 08:28
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Apr 23, 2024
Bumps [com.google.guava:guava](https://github.com/google/guava) from 29.0-jre to 32.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants