Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing_ForEachRestIT #3304

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Dec 1, 2023

Fixing typo in ForEachRestIt that curiously only fails for quarkus 3 (json parser is probably more picky now)

Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -56,7 +56,7 @@ void testForEachSubflow() {
given()
.contentType(ContentType.JSON)
.accept(ContentType.JSON)
.body("{\"numbers\" : [1,2,3,4,5], \"constant\": 2}}").when()
.body("{\"numbers\" : [1,2,3,4,5], \"constant\": 2}").when()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the typo

@@ -87,7 +87,7 @@ void testWorkflowEvents() throws Exception {
String password = "buddy";

kafkaClient.consume(Set.of(EventPublisher.PROCESS_INSTANCES_TOPIC_NAME), s -> {
LOGGER.info("Received from kafka: {}", s);
LOGGER.debug("Received from kafka: {}", s);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be debug

@fjtirado fjtirado force-pushed the Fixing_ForEachRestIt branch from 82acdec to 6053bc4 Compare December 1, 2023 11:36
@fjtirado fjtirado merged commit f0f4509 into apache:quarkus-3.2LTS Dec 1, 2023
1 of 5 checks passed
@fjtirado fjtirado deleted the Fixing_ForEachRestIt branch December 1, 2023 14:56
tkobayas pushed a commit to tkobayas/kogito-runtimes that referenced this pull request Dec 14, 2023
* Fixing_ForEachRestIT

* Formatting
mariofusco pushed a commit that referenced this pull request Dec 15, 2023
* Fixing_ForEachRestIT

* Formatting
mariofusco added a commit that referenced this pull request Dec 15, 2023
* Bump to Quarkus 3.2.9.Final

* [Quarkus 3] Updated rewrite data

* fixed quarkus3 patches

* Apply patches

* wip : fix jakarta.validation-api version

* TEMPORARY: adjust pipeline config

* CI - limit generated jobs

* CI: update mvn and jdk in GHA

* Fixing_ForEachRestIT (#3304)

* Fixing_ForEachRestIT

* Formatting

* kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon (#3303)

* kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon
* `keycloak-spring-boot-starter` removal in favour of springboot ouath2
* IT test fixes
* upgrade `quarkus-embedded-postgresql` version

* A property that use to be optional is now mandatory.

* Formatting (#3306)

MVn sort imports alphabetically, Jakarta is now before Java

* Fix #3308 - Configure SpringBoot Kubernetes to add Client in test context (#3311)

* Fix #3308 - Configure SpringBoot Kubernetes to add Client in test context

Signed-off-by: Ricardo Zanini <[email protected]>

* Add rockd temps to gitignore

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>

* issues#3320 Flaky timeout tests (#3321)

- Disabled until they get fixed/stable

* Using different topics (#3322)

* Fixing Fabric8 version alignment on Quarkus and SB (#3324)

Signed-off-by: Ricardo Zanini <[email protected]>

* Cancel should not interrupt current thread (#3325)

* Do not interrut in CancelActionCommand (#3326)

* There is not need to to do that check (#3329)

* - Removing @lazy injections on RestWorkItemHandler constructors (#3330)

* wip

---------

Signed-off-by: Ricardo Zanini <[email protected]>
Co-authored-by: Toshiya Kobayashi <[email protected]>
Co-authored-by: jstastny-cz <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Pere Fernández <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this pull request Jan 10, 2024
* Bump to Quarkus 3.2.9.Final

* [Quarkus 3] Updated rewrite data

* fixed quarkus3 patches

* Apply patches

* wip : fix jakarta.validation-api version

* TEMPORARY: adjust pipeline config

* CI - limit generated jobs

* CI: update mvn and jdk in GHA

* Fixing_ForEachRestIT (apache#3304)

* Fixing_ForEachRestIT

* Formatting

* kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon (apache#3303)

* kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon
* `keycloak-spring-boot-starter` removal in favour of springboot ouath2
* IT test fixes
* upgrade `quarkus-embedded-postgresql` version

* A property that use to be optional is now mandatory.

* Formatting (apache#3306)

MVn sort imports alphabetically, Jakarta is now before Java

* Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context (apache#3311)

* Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context

Signed-off-by: Ricardo Zanini <[email protected]>

* Add rockd temps to gitignore

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>

* issues#3320 Flaky timeout tests (apache#3321)

- Disabled until they get fixed/stable

* Using different topics (apache#3322)

* Fixing Fabric8 version alignment on Quarkus and SB (apache#3324)

Signed-off-by: Ricardo Zanini <[email protected]>

* Cancel should not interrupt current thread (apache#3325)

* Do not interrut in CancelActionCommand (apache#3326)

* There is not need to to do that check (apache#3329)

* - Removing @lazy injections on RestWorkItemHandler constructors (apache#3330)

* wip

---------

Signed-off-by: Ricardo Zanini <[email protected]>
Co-authored-by: Toshiya Kobayashi <[email protected]>
Co-authored-by: jstastny-cz <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Pere Fernández <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jan 17, 2024
* Bump to Quarkus 3.2.9.Final

* [Quarkus 3] Updated rewrite data

* fixed quarkus3 patches

* Apply patches

* wip : fix jakarta.validation-api version

* TEMPORARY: adjust pipeline config

* CI - limit generated jobs

* CI: update mvn and jdk in GHA

* Fixing_ForEachRestIT (apache#3304)

* Fixing_ForEachRestIT

* Formatting

* kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon (apache#3303)

* kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon
* `keycloak-spring-boot-starter` removal in favour of springboot ouath2
* IT test fixes
* upgrade `quarkus-embedded-postgresql` version

* A property that use to be optional is now mandatory.

* Formatting (apache#3306)

MVn sort imports alphabetically, Jakarta is now before Java

* Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context (apache#3311)

* Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context

Signed-off-by: Ricardo Zanini <[email protected]>

* Add rockd temps to gitignore

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>

* issues#3320 Flaky timeout tests (apache#3321)

- Disabled until they get fixed/stable

* Using different topics (apache#3322)

* Fixing Fabric8 version alignment on Quarkus and SB (apache#3324)

Signed-off-by: Ricardo Zanini <[email protected]>

* Cancel should not interrupt current thread (apache#3325)

* Do not interrut in CancelActionCommand (apache#3326)

* There is not need to to do that check (apache#3329)

* - Removing @lazy injections on RestWorkItemHandler constructors (apache#3330)

* wip

---------

Signed-off-by: Ricardo Zanini <[email protected]>
Co-authored-by: Toshiya Kobayashi <[email protected]>
Co-authored-by: jstastny-cz <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Pere Fernández <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
yesamer pushed a commit to yesamer/kogito-runtimes that referenced this pull request Apr 22, 2024
* Bump to Quarkus 3.2.9.Final

* [Quarkus 3] Updated rewrite data

* fixed quarkus3 patches

* Apply patches

* wip : fix jakarta.validation-api version

* TEMPORARY: adjust pipeline config

* CI - limit generated jobs

* CI: update mvn and jdk in GHA

* Fixing_ForEachRestIT (apache#3304)

* Fixing_ForEachRestIT

* Formatting

* kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon (apache#3303)

* kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon
* `keycloak-spring-boot-starter` removal in favour of springboot ouath2
* IT test fixes
* upgrade `quarkus-embedded-postgresql` version

* A property that use to be optional is now mandatory.

* Formatting (apache#3306)

MVn sort imports alphabetically, Jakarta is now before Java

* Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context (apache#3311)

* Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context

Signed-off-by: Ricardo Zanini <[email protected]>

* Add rockd temps to gitignore

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>

* issues#3320 Flaky timeout tests (apache#3321)

- Disabled until they get fixed/stable

* Using different topics (apache#3322)

* Fixing Fabric8 version alignment on Quarkus and SB (apache#3324)

Signed-off-by: Ricardo Zanini <[email protected]>

* Cancel should not interrupt current thread (apache#3325)

* Do not interrut in CancelActionCommand (apache#3326)

* There is not need to to do that check (apache#3329)

* - Removing @lazy injections on RestWorkItemHandler constructors (apache#3330)

* wip

---------

Signed-off-by: Ricardo Zanini <[email protected]>
Co-authored-by: Toshiya Kobayashi <[email protected]>
Co-authored-by: jstastny-cz <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Pere Fernández <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants