#817 - removing oracle database dependency

[porcelli]

This PR is related to apache/incubator-kie-issues#817

Related PRs:

• #817 - removing oracle database dependency incubator-kie-kogito-apps#1968

[mariofusco]

I approved this PR not because I'm a fan of removing potentially useful features in this way, but because I didn't see any alternative if we want to move forward with the first Apache release.

Thinking twice, if we understand correctly, what it is not compliant with Apache policies is the use of the Oracle driver, that however we only use for tests (and in all honesty is highly questionable if a dependency with test scope should be considered among our actual dependencies and block the release). If that's the case the other alternative would be to keep the addon as it is and just remove the test. It's true that in this way we will end up with an untested addon, but I would argue that keeping this feature untested would be better than totally removing it. And on the longer term we could move this test, and maybe other with similar problems, into another project (maybe back in kiegroup?) so it won't be under the Apache control, but still we will be notified if a future change will break the addon.

@porcelli please let me know if the alternative that I'm suggesting makes sense.

[fjtirado]

Folllowing Mario s comment, which I fully concur with, if we interpret the legal restriction to also bind test dependencies, which is highly debatable, this PR (and the related one in Apps) should just have disable the oracle test (which I think does not depend on the driver for compilation) and removal of the test dependency from the pom. Since we are already disabling flaky test, that should not cause any issue.

[ricardozanini]

+1 to not remove completely the addon. It was part of a community contribution. Just remove the driver dependency and disable the test with the comment "Disabling duo to license issues". So one could fork, and test it if needed.

[fjtirado]

Already implemented