[Fix_3672] Process instance in Error state is not longer active #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3373 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3373/1/display/redirect Test results:
Those are the test failures: org.kie.kogito.infinispan.CacheProcessInstancesIT.testFindByIdReadModeExpected size: 1 but was: 0 in: [] org.kie.persistence.jdbc.OracleProcessInstancesIT.testMultipleProcessesExpected size: 1 but was: 0 in: [] org.kie.persistence.jdbc.PostgreSqlProcessInstancesIT.testMultipleProcessesExpected size: 1 but was: 0 in: [] org.kie.persistence.jdbc.PostgreSqlProcessInstancesLockIT.testMultipleProcessesExpected size: 1 but was: 0 in: [] org.kie.kogito.mongodb.MongoDBProcessInstancesIT.testFindByIdReadModeWithTransactionExpected size: 1 but was: 0 in: [] org.kie.kogito.mongodb.MongoDBProcessInstancesIT.testFindByIdReadModeExpected size: 1 but was: 0 in: [] org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testMultipleProcessesExpected size: 1 but was: 0 in: [] org.kie.persistence.postgresql.PostgresqlProcessInstancesWithLockIT.testMultipleProcessesExpected size: 1 but was: 0 in: [] org.jbpm.bpmn2.ActivityTest.testUserTaskWithAssignmentCould not find process instance for id 0c77e4c5-372a-4148-9de0-c01678a66e98org.jbpm.bpmn2.canonical.ActivityGenerationModelTest.testExclusiveSplitRetriggerAfterErrornull sourceorg.kie.kogito.codegen.tests.PublishEventIT.testServiceTaskProcessWithErrorExpected size: 1 but was: 2 in: [ProcessInstanceStateDataEvent {specVersion=1.0, id='1b6669f5-7ee1-4fe4-825d-33bfe00a5cbc', source=http://myhost/ServiceProcessDifferentOperations, type='ProcessInstanceStateDataEvent', time=2024-01-25T13:33:57.271872662-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Thu Jan 25 13:33:57 EST 2024, eventUser=null, eventType=2, processId=ServiceProcessDifferentOperations, processVersion=1.0, processType=BPMN, processInstanceId=4b7897de-53fc-4207-9c9f-2613d576f600, businessKey=null, processName=Service Process, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=5, roles=null], kogitoProcessInstanceId='4b7897de-53fc-4207-9c9f-2613d576f600', kogitoRootProcessInstanceId='null', kogitoProcessId='ServiceProcessDifferentOperations', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=4b7897de-53fc-4207-9c9f-2613d576f600, kogitoprocist=5, kogitoprocversion=1.0, kogitoprocid=ServiceProcessDifferentOperations, kogitoaddons=test}}, ProcessInstanceStateDataEvent {specVersion=1.0, id='4acd7dc4-369a-416e-b499-57d4deced604', source=http://myhost/ServiceProcessDifferentOperations, type='ProcessInstanceStateDataEvent', time=2024-01-25T13:33:57.273649616-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Thu Jan 25 13:33:57 EST 2024, eventUser=null, eventType=1, processId=ServiceProcessDifferentOperations, processVersion=1.0, processType=BPMN, processInstanceId=4b7897de-53fc-4207-9c9f-2613d576f600, businessKey=null, processName=Service Process, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=5, roles=null], kogitoProcessInstanceId='4b7897de-53fc-4207-9c9f-2613d576f600', kogitoRootProcessInstanceId='null', kogitoProcessId='ServiceProcessDifferentOperations', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=4b7897de-53fc-4207-9c9f-2613d576f600, kogitoprocist=5, kogitoprocversion=1.0, kogitoprocid=ServiceProcessDifferentOperations, kogitoaddons=test}}] org.kie.kogito.quarkus.workflows.ExpressionRestIT.testExpressionOutputValidation1 expectation failed.JSON path id doesn't match. Expected: not null Actual: null |
|
Closing because forcing error to finish the process is not compatible with retrigger functionality, which is exposed in several existing endpoints. We need to reevaluate how the current implementation fits with straight trhough process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3372