Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix_#3366] Configuring exception propagation for event publishing #3380

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Jan 29, 2024

The new configurable properties are

kogito.events.processinstances.errors.propagate
kogito.events.processdefinitions.errors.propagate
kogito.events.usertasks.errors.propagate

Default value is false, so exception wont be propaged unless explicitly indicated

I manually tested that when
kogito.events.processdefinitions.errors.propagate=true
and
mp.messaging.outgoing.kogito-processdefinitions-events.connector=quarkus-http
if there is not data-index, quarkus wont start.

2024-01-30 19:11:39,813 ERROR [io.qua.run.Application] (Quarkus Main Thread) Failed to start application (with profile [dev]): java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:111)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:71)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:44)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:124)
	at io.quarkus.runner.GeneratedMain.main(Unknown Source)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:104)
	at java.base/java.lang.Thread.run(Thread.java:840)

@fjtirado fjtirado requested review from wmedvede and nmirasch January 29, 2024 13:19
@fjtirado fjtirado changed the title [Fix_#3366] Making exception propagation for event publishing [Fix_#3366] Configuring exception propagation for event publishing Jan 29, 2024
@ricardozanini ricardozanini linked an issue Jan 29, 2024 that may be closed by this pull request
@fjtirado fjtirado merged commit 1bd8166 into apache:main Jan 30, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Feb 5, 2024
…pache#3380)

* [Fix_#3366] Making exception propagation for event publishing
configurable

* [Fix_#3366] Logging refinement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants