Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ce content type when using binary #3391

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Feb 5, 2024

CloudEvent+json content type should be used only in structured mode
Merge with apache/incubator-kie-kogito-examples#1864

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just define the constant as private.
Well done @fjtirado !

@fjtirado fjtirado force-pushed the fixing_ce_content_type branch from 04eb786 to 3767fb8 Compare February 5, 2024 12:38
@fjtirado fjtirado merged commit eec6164 into apache:main Feb 5, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Feb 6, 2024
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Feb 6, 2024
rgdoliveira added a commit to kiegroup/kogito-runtimes that referenced this pull request Feb 6, 2024
[9.99.x-prod] Fixing ce content type when using binary (apache#3391)
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this pull request Feb 13, 2024
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants