-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix_#3413] Speed up businesskey query performance #3441
Conversation
0c729c7
to
ab9f0fa
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3441 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3441/6/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.EventFlowIT.testNotStartingEvent1 expectation failed.Expected status code <201> but was <500>. |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3441 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3441/8/display/redirect Test results:
Those are the test failures: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments.
good job!
...common/persistence/jdbc/src/main/java/org/kie/kogito/persistence/jdbc/GenericRepository.java
Outdated
Show resolved
Hide resolved
...common/persistence/jdbc/src/main/java/org/kie/kogito/persistence/jdbc/GenericRepository.java
Outdated
Show resolved
Hide resolved
addons/common/persistence/jdbc/src/main/resources/db/ansi/V10.0.0__add_business_key_ansi.sql
Outdated
Show resolved
Hide resolved
...n/persistence/jdbc/src/main/resources/db/postgresql/V10.0.0__add_business_key_PostgreSQL.sql
Outdated
Show resolved
Hide resolved
...common/persistence/jdbc/src/main/java/org/kie/kogito/persistence/jdbc/GenericRepository.java
Show resolved
Hide resolved
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3441 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3441/12/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.EventFlowIT.testNotStartingEventCondition with alias 'dead' didn't complete within 15 seconds because assertion condition defined as a org.kie.kogito.quarkus.workflows.AssuredTestUtils 1 expectation failed.Expected status code <404> but was <200>. . |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3441 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3441/13/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.EventFlowIT.testNotStartingEventCondition with alias 'dead' didn't complete within 15 seconds because assertion condition defined as a org.kie.kogito.quarkus.workflows.AssuredTestUtils 1 expectation failed.Expected status code <404> but was <200>. . |
* [Fix apache#3413] Speed up business key query performance * [Fix apache#3413] Walters comments * [Fix apache#3413] Fixing flaky test
A new mapping table has been added.
Test already existed for business key in serverless workflow extension.
Fixes #3413