Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix_#3413] Speed up businesskey query performance #3441

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Mar 14, 2024

A new mapping table has been added.
Test already existed for business key in serverless workflow extension.
Fixes #3413

@fjtirado fjtirado force-pushed the Fix_#3413 branch 6 times, most recently from 0c729c7 to ab9f0fa Compare March 14, 2024 12:12
@kie-ci3
Copy link
Contributor

kie-ci3 commented Mar 14, 2024

PR job #6 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3441 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3441/6/display/redirect

Test results:

  • PASSED: 3253
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.EventFlowIT.testNotStartingEvent 1 expectation failed.
Expected status code <201> but was <500>.

@apache apache deleted a comment from kie-ci3 Mar 14, 2024
@kie-ci3
Copy link
Contributor

kie-ci3 commented Mar 14, 2024

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3441 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3441/8/display/redirect

Test results:

  • PASSED: 3253
  • FAILED: 1

Those are the test failures:

org.jbpm.process.TimerTest.testTimer
expected: 4
but was: 5

Copy link
Contributor

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments.
good job!

@kie-ci3
Copy link
Contributor

kie-ci3 commented Mar 15, 2024

PR job #12 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3441 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3441/12/display/redirect

Test results:

  • PASSED: 3253
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.EventFlowIT.testNotStartingEvent Condition with alias 'dead' didn't complete within 15 seconds because assertion condition defined as a org.kie.kogito.quarkus.workflows.AssuredTestUtils 1 expectation failed.
Expected status code <404> but was <200>.
.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Mar 15, 2024

PR job #13 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3441 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3441/13/display/redirect

Test results:

  • PASSED: 3253
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.EventFlowIT.testNotStartingEvent Condition with alias 'dead' didn't complete within 15 seconds because assertion condition defined as a org.kie.kogito.quarkus.workflows.AssuredTestUtils 1 expectation failed.
Expected status code <404> but was <200>.
.

@fjtirado fjtirado merged commit 1c82652 into apache:main Mar 16, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Mar 27, 2024
* [Fix apache#3413] Speed up business key query performance

* [Fix apache#3413] Walters comments

* [Fix apache#3413] Fixing flaky test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to query for BusinessKey in JDBC schema
4 participants