Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3460] Fix ClassCastException on Exception mapping #3461

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Apr 3, 2024

Fixes #3460

@fjtirado fjtirado requested review from nmirasch and gmunozfe April 3, 2024 20:25
@fjtirado fjtirado force-pushed the Fix_#3460 branch 2 times, most recently from e373e2f to 623dea1 Compare April 3, 2024 20:27
@kie-ci3
Copy link
Contributor

kie-ci3 commented Apr 3, 2024

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3461 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3461/3/display/redirect

Test results:

  • PASSED: 3253
  • FAILED: 2

Those are the test failures:

org.kie.kogito.quarkus.workflows.ExpressionRestIT.testExpressionOutputValidation 1 expectation failed.
JSON path id doesn't match.
Expected: not null
Actual: null
org.kie.kogito.quarkus.workflows.RetriggerIT.testRetrigger Unnamed path parameter cannot be null (path parameter at index 0 is null)

@kie-ci3
Copy link
Contributor

kie-ci3 commented Apr 4, 2024

PR job #4 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3461 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3461/4/display/redirect

Test results:

  • PASSED: 3254
  • FAILED: 1

Those are the test failures:

org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.execute404 1 expectation failed.
Expected status code <500> but was <404>.

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great solution @fjtirado !

@fjtirado fjtirado merged commit 19e3630 into apache:main Apr 5, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Apr 16, 2024
…#3461)

* [Fix apache#3460] Fix ClassCastException on Exception mapping

* Revert "[Fix apache#3460] Fix ClassCastException on Exception mapping"

This reverts commit 6f729ff.

* [Fix apache#3460] Conservative approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem handling ProcessInstanceExecutionException
4 participants