-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #3460] Fix ClassCastException on Exception mapping #3461
Conversation
e373e2f
to
623dea1
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3461 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3461/3/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.ExpressionRestIT.testExpressionOutputValidation1 expectation failed.JSON path id doesn't match. Expected: not null Actual: null org.kie.kogito.quarkus.workflows.RetriggerIT.testRetriggerUnnamed path parameter cannot be null (path parameter at index 0 is null) |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3461 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3461/4/display/redirect Test results:
Those are the test failures: org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.execute4041 expectation failed.Expected status code <500> but was <404>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great solution @fjtirado !
…#3461) * [Fix apache#3460] Fix ClassCastException on Exception mapping * Revert "[Fix apache#3460] Fix ClassCastException on Exception mapping" This reverts commit 6f729ff. * [Fix apache#3460] Conservative approach
Fixes #3460