Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3524] Use timeout per Event state, not per Event type #3528

Merged
merged 1 commit into from
May 27, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented May 22, 2024

Fix #3524
This rollback the change done with KOGITO-9785, restoring timeout functionality as it was and implements the error handling in a different way.

@fjtirado fjtirado requested a review from wmedvede May 22, 2024 18:26
@fjtirado fjtirado marked this pull request as draft May 22, 2024 18:28
@fjtirado fjtirado force-pushed the Fix_#3524 branch 3 times, most recently from b5fec23 to 5058a5a Compare May 23, 2024 09:27
@fjtirado fjtirado requested a review from gmunozfe May 23, 2024 09:35
@fjtirado fjtirado marked this pull request as ready for review May 23, 2024 09:49
@apache apache deleted a comment from kie-ci3 May 23, 2024
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, awesome work @fjtirado !

Copy link
Contributor

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fjtirado fjtirado merged commit f8c8f2e into apache:main May 27, 2024
4 of 11 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Event state creates two jobs
3 participants