Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix_#3546] NodeInstanceFactoryProvided not included in native build #3548

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Jun 4, 2024

Fix #3546. This is an issue in native build consequence of the refactor done by #3482
I think including the service loader classes should be enough for native compiler to realize it should include all node classes, but @domhanak please let us know if the issue is fixed by this change

@fjtirado
Copy link
Contributor Author

fjtirado commented Jun 4, 2024

@domhanak Stil not working. It seems more stuff needs to be added. Working on that

@fjtirado fjtirado marked this pull request as draft June 4, 2024 11:26
@fjtirado fjtirado marked this pull request as ready for review June 4, 2024 15:48
@fjtirado
Copy link
Contributor Author

fjtirado commented Jun 4, 2024

@domhanak Working now, please review

@elguardian
Copy link
Contributor

@fjtirado this was fixed in documentation as for service loader it is required

uarkus.native.auto-service-loader-registration

This fixes this classloaders and futures ones. propably it is better solution to add this into an application.properties

@fjtirado
Copy link
Contributor Author

fjtirado commented Jun 6, 2024

@fjtirado this was fixed in documentation as for service loader it is required

uarkus.native.auto-service-loader-registration

This fixes this classloaders and futures ones. propably it is better solution to add this into an application.properties

Ill try and let you know (Im not sure if setting that property in the quarkus extension automatically scan the META-INF of all dependencies, in which case is indeed a better solution or it just scans the extension one, in which case it wont work)

@fjtirado
Copy link
Contributor Author

fjtirado commented Jun 6, 2024

Updated to use quarkus property rather than explicitly naming the service loader involved, thanks @elguardian

@fjtirado fjtirado merged commit e449f3d into apache:main Jun 7, 2024
5 of 6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jun 10, 2024
…pache#3548)

* [Fix_#3546] NodeInstanceFactoryProvided not included in native build

* [Fix_#3546] Approach suggested by Enrique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad response from example deployed using native image
3 participants