-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix_#3546] NodeInstanceFactoryProvided not included in native build #3548
Conversation
@domhanak Stil not working. It seems more stuff needs to be added. Working on that |
@domhanak Working now, please review |
@fjtirado this was fixed in documentation as for service loader it is required uarkus.native.auto-service-loader-registration This fixes this classloaders and futures ones. propably it is better solution to add this into an application.properties |
Ill try and let you know (Im not sure if setting that property in the quarkus extension automatically scan the META-INF of all dependencies, in which case is indeed a better solution or it just scans the extension one, in which case it wont work) |
Updated to use quarkus property rather than explicitly naming the service loader involved, thanks @elguardian |
…pache#3548) * [Fix_#3546] NodeInstanceFactoryProvided not included in native build * [Fix_#3546] Approach suggested by Enrique
Fix #3546. This is an issue in native build consequence of the refactor done by #3482
I think including the service loader classes should be enough for native compiler to realize it should include all node classes, but @domhanak please let us know if the issue is fixed by this change