Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#667: fix cleanup and settingsXml handling #3010

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

jstastny-cz
Copy link
Contributor

@jstastny-cz jstastny-cz commented Nov 1, 2023

After #3009

apache/incubator-kie-issues#667

Fixing cleanup and settings.xml pipeline configuration to work correctly in ASF Jenkins.

  • Deferred wipeout was causing issues when invoked in early stages
  • Docker cleanup can't be done since the overall build is in docker container that uses the docker.sock from the host - it would attempt to erase itself.
  • withSettingsXmlId shared library method does imply usage of a prohibited groovy method, thus replacing with explicit configFileProvider and passing as withSettingsXmlFile goes around that part of code.

Complete list:
apache/incubator-kie-kogito-pipelines#1113
apache/incubator-kie-kogito-runtimes#3272
apache/incubator-kie-kogito-apps#1909
apache/incubator-kie-kogito-examples#1820
apache/incubator-kie-drools#5572
#3010
apache/incubator-kie-optaplanner-quickstarts#613
apache/incubator-kie-kogito-docs#514
apache/incubator-kie-docs#4531
apache/incubator-kie-benchmarks#273

@kie-ci3
Copy link

kie-ci3 commented Nov 1, 2023

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-optaplanner/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-optaplanner -u #3010 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/optaplanner/job/main/job/pullrequest_jobs/job/optaplanner-pr/job/PR-3010/1/display/redirect

Test results:

  • PASSED: 5173
  • FAILED: 1

Those are the test failures:

org.optaplanner.core.config.solver.SolverConfigMultiThreadedTest.solvingWithTooHighThreadCountFinishes solvingWithTooHighThreadCountFinishes() timed out after 5 seconds

@jstastny-cz jstastny-cz marked this pull request as ready for review November 3, 2023 13:29
@jstastny-cz jstastny-cz merged commit 580520a into apache:main Nov 3, 2023
@jstastny-cz jstastny-cz deleted the kie-issues_667 branch November 3, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants