Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Extract datasource proxy metadata #6722

Open
wants to merge 9 commits into
base: 2.x
Choose a base branch
from

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Aug 2, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes: #6721

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 70.70707% with 29 lines in your changes missing coverage. Please review.

Project coverage is 50.78%. Comparing base (d0f8c6f) to head (11213ab).

Files Patch % Lines
...asource/metadata/MySQLDataSourceProxyMetadata.java 43.90% 19 Missing and 4 partials ⚠️
...rg/apache/seata/rm/datasource/DataSourceProxy.java 71.42% 1 Missing and 1 partial ⚠️
...atasource/SeataDataSourceProxyMetadataFactory.java 83.33% 1 Missing and 1 partial ⚠️
.../rm/datasource/exec/mysql/MySQLInsertExecutor.java 88.88% 0 Missing and 1 partial ⚠️
...ource/metadata/DefaultDataSourceProxyMetadata.java 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6722      +/-   ##
============================================
+ Coverage     50.24%   50.78%   +0.53%     
- Complexity     5854     5919      +65     
============================================
  Files          1058     1062       +4     
  Lines         36707    36725      +18     
  Branches       4364     4365       +1     
============================================
+ Hits          18442    18649     +207     
+ Misses        16431    16186     -245     
- Partials       1834     1890      +56     
Files Coverage Δ
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 78.48% <100.00%> (ø)
...urce/metadata/AbstractDataSourceProxyMetadata.java 100.00% <100.00%> (ø)
.../rm/datasource/undo/mysql/MySQLUndoLogManager.java 30.00% <100.00%> (ø)
.../rm/datasource/exec/mysql/MySQLInsertExecutor.java 72.41% <88.88%> (-2.33%) ⬇️
...ource/metadata/DefaultDataSourceProxyMetadata.java 83.33% <83.33%> (ø)
...rg/apache/seata/rm/datasource/DataSourceProxy.java 79.84% <71.42%> (+10.27%) ⬆️
...atasource/SeataDataSourceProxyMetadataFactory.java 83.33% <83.33%> (ø)
...asource/metadata/MySQLDataSourceProxyMetadata.java 43.90% <43.90%> (ø)

... and 40 files with indirect coverage changes

@funky-eyes funky-eyes requested a review from l81893521 August 5, 2024 02:24
@jsbxyyx jsbxyyx changed the title refactor: Extract datasource proxy metadata optimize: Extract datasource proxy metadata Aug 19, 2024
@funky-eyes funky-eyes added this to the 2.x Backlog milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract datasource proxy metadata
2 participants