feature: Raft mode supports access outside the cluster #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
type: feature
funky-eyes
reviewed
Dec 23, 2024
|
|
||
| private static InetSocketAddress selectEndpoint(String type, Node node) { | ||
| if (StringUtils.isBlank(PREFERRED_NETWORKS)) { | ||
| // 采取默认的方式，直接使用node.control node.transaction |
There was a problem hiding this comment.
Suggested change
| // 采取默认的方式，直接使用node.control node.transaction | |
| // Use the default method, directly using node.control and node.transaction |
| @@ -366,7 +366,7 @@ public RaftClusterMetadata changeOrInitRaftClusterMetadata() { | |||
| Integer.parseInt( | |||
| ((Environment)ObjectHolder.INSTANCE.getObject(OBJECT_KEY_SPRING_CONFIGURABLE_ENVIRONMENT)) | |||
| .getProperty("server.port", String.valueOf(7091))), | |||
| group, Collections.emptyMap()); | |||
| group, new HashMap<>()); | |||
There was a problem hiding this comment.
Why change to new HashMap < > ()
There was a problem hiding this comment.
因为Collections.emptyMap()返回的集合使用了final修饰，导致我进行put操作时，报错，unsupoort...
| @@ -406,7 +406,7 @@ private void syncCurrentNodeInfo(PeerId leaderPeerId) { | |||
| Integer.parseInt( | |||
| ((Environment)ObjectHolder.INSTANCE.getObject(OBJECT_KEY_SPRING_CONFIGURABLE_ENVIRONMENT)) | |||
| .getProperty("server.port", String.valueOf(7091))), | |||
| group, Collections.emptyMap()); | |||
| group, new HashMap<>()); | |||
| @@ -55,6 +58,10 @@ public Node createNode(String host, int txPort, int internalPort, int controlPor | |||
| node.setGroup(group); | |||
| node.setVersion(Version.getCurrent()); | |||
| node.setInternal(node.createEndpoint(host, internalPort, "raft")); | |||
| String serverRegistryMetadataExternalValue = System.getProperty("SERVER_REGISTRY_METADATA_EXTERNAL_VALUE"); | |||
There was a problem hiding this comment.
不应该这样读取，如果有用户直接使用properties配置文件去配置怎么办？应该通过下面这样的方式读取
It should not be read like this. What if a user directly uses the properties configuration file to configure it? It should be read in the following way
ConfigurableEnvironment environment=ObjectHolder.INSTANCE.getObject(OBJECT_KEY_SPRING_CONFIGURABLE_ENVIRONMENT);
environment.resolvePlaceholders("${seata.registry.metadata.external:${registry.metadata.external:}}")
Comment on lines
+302
to
+316
| private static String selectTransactionEndpointStr(Node node) { | ||
| InetSocketAddress transaction = selectTransactionEndpoint( node); | ||
| return NetUtil.toStringAddress(transaction); | ||
| } | ||
|
|
||
| private static InetSocketAddress selectControlEndpoint(Node node) { | ||
| return selectEndpoint("control", node); | ||
| } | ||
|
|
||
| private static InetSocketAddress selectTransactionEndpoint(Node node) { | ||
| return selectEndpoint("transaction", node); | ||
| } | ||
|
|
||
| private static InetSocketAddress selectEndpoint(String type, Node node) { | ||
| if (StringUtils.isBlank(PREFERRED_NETWORKS)) { |
There was a problem hiding this comment.
请增加这些方法的测试用例
Please add test cases for these methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
现有raft sdk如果在k8s环境下，客户端集群外访问，无法通过域名方式链接raft node，造成无法通信。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews