Skip to content

Commit

Permalink
[ISSUE-3064][Improve] Improve streampark-console method name base on …
Browse files Browse the repository at this point in the history
…[3.1 Naming Style] (#3364)
  • Loading branch information
VampireAchao authored Nov 30, 2023
1 parent 9c06a86 commit 0a660d0
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public RestResponse get(String id) throws InternalException {
@Operation(summary = "List the applications sql histories")
@PostMapping("history")
public RestResponse sqlhistory(Application application) {
List<FlinkSql> sqlList = flinkSqlService.history(application);
List<FlinkSql> sqlList = flinkSqlService.listFlinkSqlHistory(application);
return RestResponse.success(sqlList);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,14 @@ public RestResponse exists(Project project) {
@Operation(summary = "List project modules")
@PostMapping("modules")
public RestResponse modules(Long id) {
List<String> result = projectService.modules(id);
List<String> result = projectService.listModules(id);
return RestResponse.success().data(result);
}

@Operation(summary = "List project jars")
@PostMapping("jars")
public RestResponse jars(Project project) {
List<String> result = projectService.jars(project);
List<String> result = projectService.listJars(project);
return RestResponse.success().data(result);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public interface FlinkSqlService extends IService<FlinkSql> {

FlinkSql getLatestFlinkSql(Long appId, boolean decode);

List<FlinkSql> history(Application application);
List<FlinkSql> listFlinkSqlHistory(Application application);

FlinkSql getCandidate(Long appId, CandidateTypeEnum type);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ public interface ProjectService extends IService<Project> {

RestResponse getBuildLog(Long id, Long startOffset);

List<String> modules(Long id);
List<String> listModules(Long id);

List<String> jars(Project project);
List<String> listJars(Project project);

List<Map<String, Object>> listConf(Project project);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public void setCandidate(CandidateTypeEnum candidateTypeEnum, Long appId, Long s
}

@Override
public List<FlinkSql> history(Application application) {
public List<FlinkSql> listFlinkSqlHistory(Application application) {
LambdaQueryWrapper<FlinkSql> queryWrapper =
new LambdaQueryWrapper<FlinkSql>()
.eq(FlinkSql::getAppId, application.getId())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public void build(Long id) throws Exception {
}

@Override
public List<String> modules(Long id) {
public List<String> listModules(Long id) {
Project project = getById(id);
Utils.notNull(project);

Expand All @@ -245,7 +245,7 @@ public List<String> modules(Long id) {
}

@Override
public List<String> jars(Project project) {
public List<String> listJars(Project project) {
List<String> jarList = new ArrayList<>(0);
ApiAlertException.throwIfNull(
project.getModule(), "Project module can't be null, please check.");
Expand Down

0 comments on commit 0a660d0

Please sign in to comment.