[ISSUE-3075][Improve] Improve streampark-console module base on [5 Log]

#3075 (#3229) Co-authored-by: jaslou <jaslouxzhlqq.com>
apache · Oct 10, 2023 · 1f35c80 · 1f35c80
1 parent babb494
commit 1f35c80
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/...onsole-service/src/main/java/org/apache/streampark/console/core/aspect/ConsoleAspect.java b/...onsole-service/src/main/java/org/apache/streampark/console/core/aspect/ConsoleAspect.java
@@ -73,7 +73,9 @@ public void apiAccess() {}
   @Around(value = "apiAccess()")
   public RestResponse apiAccess(ProceedingJoinPoint joinPoint) throws Throwable {
     MethodSignature methodSignature = (MethodSignature) joinPoint.getSignature();
-    log.debug("restResponse aspect, method:{}", methodSignature.getName());
+    if (log.isDebugEnabled()) {
+      log.debug("restResponse aspect, method:{}", methodSignature.getName());
+    }
     Boolean isApi =
         (Boolean) SecurityUtils.getSubject().getSession().getAttribute(AccessToken.IS_API_TOKEN);
     if (Objects.nonNull(isApi) && isApi) {
@@ -91,7 +93,9 @@ public void appUpdated() {}
   @Around("appUpdated()")
   public Object appUpdated(ProceedingJoinPoint joinPoint) throws Throwable {
     MethodSignature methodSignature = (MethodSignature) joinPoint.getSignature();
-    log.debug("appUpdated aspect, method:{}", methodSignature.getName());
+    if (log.isDebugEnabled()) {
+      log.debug("appUpdated aspect, method:{}", methodSignature.getName());
+    }
     Object target = joinPoint.proceed();
     flinkAppHttpWatcher.init();
     return target;

diff --git a/...rc/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java b/...rc/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
@@ -438,7 +438,7 @@ private DeployResponse deployInternal(FlinkCluster flinkCluster)
             flinkCluster.getClusterId(),
             flinkCluster.getId(),
             getKubernetesDeployDesc(flinkCluster, "start"));
-    log.info("Deploy cluster request " + deployRequest);
+    log.info("Deploy cluster request {}", deployRequest);
     Future<DeployResponse> future = executorService.submit(() -> FlinkClient.deploy(deployRequest));
     return future.get(60, TimeUnit.SECONDS);
   }

diff --git a/...service/src/main/java/org/apache/streampark/console/core/websocket/WebSocketEndpoint.java b/...service/src/main/java/org/apache/streampark/console/core/websocket/WebSocketEndpoint.java
@@ -47,15 +47,19 @@ public class WebSocketEndpoint {
 
   @OnOpen
   public void onOpen(Session session, @PathParam("id") String id) {
-    log.debug("websocket onOpen....");
+    if (log.isDebugEnabled()) {
+      log.debug("websocket onOpen....");
+    }
     this.id = id;
     this.session = session;
     SOCKET_SESSIONS.put(id, session);
   }
 
   @OnClose
   public void onClose() throws IOException {
-    log.debug("websocket onClose....");
+    if (log.isDebugEnabled()) {
+      log.debug("websocket onClose....");
+    }
     this.session.close();
     SOCKET_SESSIONS.remove(this.id);
   }