improve FlinkClusterController.java

apache · Jan 10, 2024 · 707dd21 · 707dd21
1 parent f7ea7a0
commit 707dd21
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/...e/src/main/java/org/apache/streampark/console/core/controller/FlinkClusterController.java b/...e/src/main/java/org/apache/streampark/console/core/controller/FlinkClusterController.java
@@ -117,8 +117,8 @@ public RestResponse shutdown(FlinkCluster cluster) {
 
   @Operation(summary = "Delete flink cluster")
   @PostMapping("delete")
-  public RestResponse delete(FlinkCluster cluster) {
-    flinkClusterService.remove(cluster);
+  public RestResponse delete(Long Id) {
+    flinkClusterService.remove(Id);
     return RestResponse.success();
   }
 }
diff --git a/...service/src/main/java/org/apache/streampark/console/core/service/FlinkClusterService.java b/...service/src/main/java/org/apache/streampark/console/core/service/FlinkClusterService.java
@@ -35,7 +35,7 @@ public interface FlinkClusterService extends IService<FlinkCluster> {
 
   Boolean create(FlinkCluster flinkCluster);
 
-  void remove(FlinkCluster flinkCluster);
+  void remove(Long id);
 
   void update(FlinkCluster flinkCluster);
 

diff --git a/...rc/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java b/...rc/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
@@ -341,8 +341,7 @@ public void updateClusterState(Long id, ClusterState state) {
   }
 
   @Override
-  public void remove(FlinkCluster cluster) {
-    Long id = cluster.getId();
+  public void remove(Long id) {
     FlinkCluster flinkCluster = getById(id);
     ApiAlertException.throwIfNull(flinkCluster, "Flink cluster not exist, please check.");