Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Improve streampark-flink-client-core module base on Naming Style and add deploy log #3231

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Oct 10, 2023

What changes were proposed in this pull request

[Improve streampark-flink-client-core module base on Naming Style and add deploy log
Complete : #3224

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)
    no

@github-actions github-actions bot added the FLINK label Oct 10, 2023
@caicancai
Copy link
Member Author

The deploy log is added in order to be written in accordance with v1, but I think this log can be deleted when it becomes stable in the future

@caicancai
Copy link
Member Author

cc @RocMarshal @wolfboys

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit b7eacf8 into apache:dev Oct 10, 2023
@caicancai caicancai deleted the improve branch October 12, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants