Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] SqlDialect DEFAULT requires capitalization #3277

Merged
merged 13 commits into from
Oct 24, 2023
Merged

[Fix] SqlDialect DEFAULT requires capitalization #3277

merged 13 commits into from
Oct 24, 2023

Conversation

ChengJie1053
Copy link
Member

@ChengJie1053 ChengJie1053 commented Oct 24, 2023 •
edited
Loading

[Fix] SqlDialect DEFAULT requires capitalization

@github-actions github-actions bot added the FLINK label Oct 24, 2023
@ChengJie1053 ChengJie1053 changed the title [Fix] sqlDialect "DEFAULT" requires capitalization [Fix] SqlDialect DEFAULT requires capitalization Oct 24, 2023
wolfboys
wolfboys approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 47f50ee into apache:dev Oct 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfboys wolfboys wolfboys approved these changes

Assignees
No one assigned
Labels
FLINK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChengJie1053 @wolfboys