Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] [Flink-Kubernetes-V2] Updated the crd of flink-operator 1.16.1 #3282

Merged
merged 6 commits into from
Nov 10, 2023
Merged

[Improve] [Flink-Kubernetes-V2] Updated the crd of flink-operator 1.16.1 #3282

merged 6 commits into from
Nov 10, 2023

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Oct 25, 2023

What changes were proposed in this pull request

Updated the crd of flink-operator 1.16.1

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@github-actions github-actions bot added the FLINK label Oct 25, 2023
@caicancai
Copy link
Member Author

Currently Flink-operator 1.16 supports flink1.18, but flink1.18 cannot be supported during my testing
cc @Al-assad @wolfboys

@caicancai caicancai closed this Oct 25, 2023
@caicancai caicancai reopened this Oct 25, 2023
@Al-assad
Copy link
Member

Currently Flink-operator 1.16 supports flink1.18, but flink1.18 cannot be supported during my testing cc @Al-assad @wolfboys

Hi Cai, Flink Operator does not provide support for Flink 1.18 version currently. But if you want to preparation in advance, you can copy the corresponding crds yaml files to streampark-flink-crd/resources.

@caicancai
Copy link
Member Author

caicancai commented Oct 27, 2023

@Al-assad Hi assad, Thank you for your reply. At present, I am doing this. I find that it does not affect the previous V2 code. I'm not sure if this code is currently suitable for merging.
cc @wolfboys

@caicancai caicancai changed the title [WIP] [Improve] [Flink-Kubernetes-V2] support flink1.18 [Improve] [Flink-Kubernetes-V2] Update crd to 1.16 crd Nov 1, 2023
@caicancai
Copy link
Member Author

caicancai commented Nov 1, 2023

cc @Al-assad @wolfboys Hi,I updated the crd of flink-operator 1.16.1. It seems that there are no major changes at present. You can consider merging it.

@caicancai caicancai changed the title [Improve] [Flink-Kubernetes-V2] Update crd to 1.16 crd [Improve] [Flink-Kubernetes-V2] Updated the crd of flink-operator 1.16.1 Nov 1, 2023
@caicancai
Copy link
Member Author

@wolfboys He is able to merge without affecting the main process, and I am afraid that it will cause conflicts if it hangs for too long

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 4099a3f into apache:dev Nov 10, 2023
6 checks passed
@caicancai caicancai deleted the 1.18 branch November 10, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants