Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Improve streampark-console core package module service name base on [3.1 Naming Style] #3303

Closed
wants to merge 1 commit into from

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Nov 1, 2023

[Improve] Improve streampark-console core package module service name base on [3.1 Naming Style]

What changes were proposed in this pull request

Issue Number: fix #3295

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@caicancai
Copy link
Member Author

caicancai commented Nov 1, 2023

cc @RocMarshal @wolfboys

@VampireAchao
Copy link
Contributor

Potentially, the inconsistency arises from methods such as:

  • org.apache.streampark.console.core.mapper.ApplicationMapper#selectAppsByTeamId
  • org.apache.streampark.console.core.service.VariableService#getDependAppsPage
  • org.apache.streampark.console.core.mapper.ApplicationMapper#selectProbeApps
    ...and others.

This discrepancy creates a lack of harmony in the codebase. Therefore, I am inclined to believe that renaming 'app' to 'application' may not be the most advantageous course of action.

@caicancai caicancai closed this Nov 1, 2023
@caicancai
Copy link
Member Author

Potentially, the inconsistency arises from methods such as:

  • org.apache.streampark.console.core.mapper.ApplicationMapper#selectAppsByTeamId
  • org.apache.streampark.console.core.service.VariableService#getDependAppsPage
  • org.apache.streampark.console.core.mapper.ApplicationMapper#selectProbeApps
    ...and others.

This discrepancy creates a lack of harmony in the codebase. Therefore, I am inclined to believe that renaming 'app' to 'application' may not be the most advantageous course of action.

thank your reply

@caicancai caicancai deleted the 3064 branch November 2, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants