Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Improve streampark-flink-client-KubernetesV2 module based on [3.7 Code Comments Rule] #3305

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Nov 1, 2023

What changes were proposed in this pull request

Issue Number: close #3306

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@github-actions github-actions bot added the FLINK label Nov 1, 2023
@caicancai
Copy link
Member Author

caicancai commented Nov 1, 2023

This relates only to the KubernetesV2 module

@caicancai
Copy link
Member Author

cc @RocMarshal @wolfboys

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit beb5c6d into apache:dev Nov 1, 2023
6 checks passed
@caicancai caicancai deleted the comment branch November 2, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Improve streampark-flink-client-KubernetesV2 module based on 3.7 Code Comments Rule
2 participants