Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Improve streampark-console module base on 3.6 Control/Condition Statements #3328

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

eagleli123
Copy link
Contributor

What changes were proposed in this pull request

Issue Number: close #3069

Brief change log

[Improve] Improve streampark-console module base on 3.6 Control/Condition Statements

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (no)

@eagleli123 eagleli123 changed the title Improve streampark-console module base on [3.6 Control/Condition Stat… [Improve] Improve streampark-console module base on [3.6 Control/Condition Stat… Nov 10, 2023
@caicancai
Copy link
Member

Hi , Thank you for your contribution. Could you please improve the title? [Improve] Improve streampark-console module base on 3.6 Control/Condition Statements

@eagleli123 eagleli123 changed the title [Improve] Improve streampark-console module base on [3.6 Control/Condition Stat… [Improve] Improve streampark-console module base on [3.6 Control/Condition Statements] Nov 10, 2023
@eagleli123 eagleli123 changed the title [Improve] Improve streampark-console module base on [3.6 Control/Condition Statements] [Improve] Improve streampark-console module base on 3.6 Control/Condition Statements Nov 10, 2023
@eagleli123
Copy link
Contributor Author

Hi , Thank you for your contribution. Could you please improve the title? [Improve] Improve streampark-console module base on 3.6 Control/Condition Statements

Thanks for the reminder, the title has been modified.

@caicancai
Copy link
Member

cc @RocMarshal

@RocMarshal RocMarshal self-requested a review November 14, 2023 07:08
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, @eagleli123 Thanks for your hard work.
LGTM +1.

@RocMarshal RocMarshal merged commit 39dfd17 into apache:dev Nov 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Improve streampark-console module base on [3.6 Control/Condition Statements]
3 participants